char/sx: replace schedule_timeout() with
Subsystems (2)
PATCH 11/21 char/sx: replace schedule_timeout() with
Hi,
Please consider applying.
Description: Use msleep_interruptible() instead of schedule_timeout() to guarantee consistent timing regardless of HZ value. schedule_timeout(1) will vary between 10 and 1 milliseconds, depending on the value of HZ (100 or 1000 respectively). For consistent behavior, msleep_interruptible() should be used.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/char/sx.c +2 -6
@@ -1515,13 +1515,9 @@ static void sx_close (void *ptr)sx_reconfigure_port (port);sx_send_command (port,HS_CLOSE ,0 ,0 ); -while (to-- && (sx_read_channel_byte (port, hi_hstat) !=HS_IDLE_CLOSED )) { -set_current_state (TASK_INTERRUPTIBLE ); -schedule_timeout (1 ); -if (signal_pending (current)) +while (to-- && (sx_read_channel_byte (port, hi_hstat) !=HS_IDLE_CLOSED )) +if (msleep_interruptible (10 ))break ; - } - current->state =TASK_RUNNING ;if (sx_read_channel_byte (port, hi_hstat) !=HS_IDLE_CLOSED ) {if (sx_send_command (port,HS_FORCE_CLOSED ,-1 ,HS_IDLE_CLOSED ) !=1 ) { printk (KERN_ERR
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors