Skip to contentSkip to conversation

ppc64/pSeries_smp: replace schedule_timeout()

PATCH Applied Nishanth Aravamudan 1 participant 1 message Jan 18, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 17/21 ppc64/pSeries_smp: replace schedule_timeout()

Hi,

Please consider applying.

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. The current code is not incorrect, but msleep() is clearer in terms of the length of delay and helps make the kernel consistent.

arch/ppc64/kernel/pSeries_smp.c +1 -2
@@ -107,8 +107,7 @@ void pSeries_cpu_die(unsigned int cpu)
 		cpu_status = query_cpu_stopped(pcpu);
 		if (cpu_status == 0 || cpu_status == -1)
 			break;
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(HZ/5);
+		msleep(200);
 	}
 	if (cpu_status != 0) {
 		printk("Querying DEAD? cpu %i (%i) shows %i\n",

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors