Skip to contentSkip to conversation

x86-64: int3 no longer causes SIGTRAP in 2.6.10

PATCH Juho Snellman 3 participants 6 messages Jan 18, 2005 – Jan 19, 2005

lore
Share & tools
lore
#0 lore raw

2.6.10 changed the behaviour of the int3 instruction on x86-64. It used to result in a SIGTRAP, now it's a SIGSEGV in both native and 32-bit legacy modes. This was apparently caused by the kprobe port, specifically this part:

arch/x86_64/kernel/traps.c 2004-12-24 13:36:17 -08:00 +2 -2
@@ -862,8 +910,8 @@
        set_intr_gate(0,&divide_error);
        set_intr_gate_ist(1,&debug,DEBUG_STACK);
        set_intr_gate_ist(2,&nmi,NMI_STACK);
-       set_system_gate(3,&int3);       /* int3-5 can be called from all */
-       set_system_gate(4,&overflow);
+       set_intr_gate(3,&int3);
+       set_system_gate(4,&overflow);   /* int4-5 can be called from all */
 

Was effectively disabling int3 a conscious decision, or just an unintended side-effect? This breaks at least Steel Bank Common Lisp (x86 and x86-64) and CMU Common Lisp (x86), which use int3 for error traps and breakpoints.

Simple test case:

% cat foo.c

int main (void) {
    asm("int3");
    return 0;
}

% gcc -o foo foo.c
% ./foo
zsh: trace trap ./foo
% gcc -m32 -o foo-32 foo.c
% ./foo-32
zsh: trace trap ./foo-32

[ reboot ]

% uname -a
Linux kiki 2.6.10 #2 Sun Dec 26 04:54:05 EET 2004 x86_64 x86_64 x86_64 % ./foo
zsh: segmentation fault ./foo
% ./foo-32
zsh: segmentation fault ./foo-32

Signature · 1 line
Juho Snellman
#1 lore raw
Quoted 16 lines · Juho Snellman

2.6.10 changed the behaviour of the int3 instruction on x86-64. It used to result in a SIGTRAP, now it's a SIGSEGV in both native and 32-bit legacy modes. This was apparently caused by the kprobe port, specifically this part:

arch/x86_64/kernel/traps.c 2004-12-24 13:36:17 -08:00 +2 -2
@@ -862,8 +910,8 @@
        set_intr_gate(0,&divide_error);
        set_intr_gate_ist(1,&debug,DEBUG_STACK);
        set_intr_gate_ist(2,&nmi,NMI_STACK);
-       set_system_gate(3,&int3);       /* int3-5 can be called from all */
-       set_system_gate(4,&overflow);
+       set_intr_gate(3,&int3);
+       set_system_gate(4,&overflow);   /* int4-5 can be called from all */
 
Quoted 2 lines

Was effectively disabling int3 a conscious decision, or just an unintended side-effect? This breaks at least Steel Bank Common Lisp

It's a bug. Thanks for the report.

I'm not sure why it was even changed. Prasanna?

I think it should be just changed back. If kprobes cannot deal with traps for user space it needs to be fixed. e.g. by adding a user space check in kprobe_handler().

-Andi

Like this patch.

arch/x86_64/kernel/traps.c +1 -1
Index: linux/arch/x86_64/kernel/traps.c
===================================================================
@@ -908,7 +908,7 @@
 	set_intr_gate(0,&divide_error);
 	set_intr_gate_ist(1,&debug,DEBUG_STACK);
 	set_intr_gate_ist(2,&nmi,NMI_STACK);
-	set_intr_gate(3,&int3);
+	set_system_gate(3,&int3);
 	set_system_gate(4,&overflow);	/* int4-5 can be called from all */
 	set_system_gate(5,&bounds);
 	set_intr_gate(6,&invalid_op);
arch/x86_64/kernel/kprobes.c +2 -0
Index: linux/arch/x86_64/kernel/kprobes.c
===================================================================
@@ -297,6 +297,8 @@
 	struct die_args *args = (struct die_args *)data;
 	switch (val) {
 	case DIE_INT3:
+		if (args->regs->cs & 3)
+			return NOTIFY_DONE;
 		if (kprobe_handler(args->regs))
 			return NOTIFY_STOP;
 		break;
#2 lore raw
Quoted 23 lines · Andi Kleen
Quoted 16 lines · Juho Snellman

2.6.10 changed the behaviour of the int3 instruction on x86-64. It used to result in a SIGTRAP, now it's a SIGSEGV in both native and 32-bit legacy modes. This was apparently caused by the kprobe port, specifically this part:

arch/x86_64/kernel/traps.c 2004-12-24 13:36:17 -08:00 +2 -2
@@ -862,8 +910,8 @@
        set_intr_gate(0,&divide_error);
        set_intr_gate_ist(1,&debug,DEBUG_STACK);
        set_intr_gate_ist(2,&nmi,NMI_STACK);
-       set_system_gate(3,&int3);       /* int3-5 can be called from all */
-       set_system_gate(4,&overflow);
+       set_intr_gate(3,&int3);
+       set_system_gate(4,&overflow);   /* int4-5 can be called from all */
 
Quoted 2 lines

Was effectively disabling int3 a conscious decision, or just an unintended side-effect? This breaks at least Steel Bank Common Lisp

It's a bug. Thanks for the report.

Quoted 6 lines

I'm not sure why it was even changed. Prasanna?

I think it should be just changed back. If kprobes cannot deal with traps for user space it needs to be fixed. e.g. by adding a user space check in kprobe_handler().

Yes its a bug, we turn trap 3 into interrupt gates to ensure that it is not preemtable.

Thanks
Prasanna

Quoted 32 lines

-Andi

Like this patch.

Index: linux/arch/x86_64/kernel/traps.c
===================================================================

arch/x86_64/kernel/traps.c +1 -1
@@ -908,7 +908,7 @@
 	set_intr_gate(0,&divide_error);
 	set_intr_gate_ist(1,&debug,DEBUG_STACK);
 	set_intr_gate_ist(2,&nmi,NMI_STACK);
-	set_intr_gate(3,&int3);
+	set_system_gate(3,&int3);
 	set_system_gate(4,&overflow);	/* int4-5 can be called from all */
 	set_system_gate(5,&bounds);
 	set_intr_gate(6,&invalid_op);

Index: linux/arch/x86_64/kernel/kprobes.c
===================================================================

arch/x86_64/kernel/kprobes.c +2 -0
@@ -297,6 +297,8 @@
 	struct die_args *args = (struct die_args *)data;
 	switch (val) {
 	case DIE_INT3:
+		if (args->regs->cs & 3)
+			return NOTIFY_DONE;
 		if (kprobe_handler(args->regs))
 			return NOTIFY_STOP;
 		break;
Signature · 8 lines
Have a Nice Day!

Thanks & Regards
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<[email protected]>
#3 lore raw
Quoted 1 line

Yes its a bug, we turn trap 3 into interrupt gates to ensure that it is not preemtable.

Is the patch ok for you?

-Andi

Quoted 30 lines
Quoted 30 lines

Like this patch.

Index: linux/arch/x86_64/kernel/traps.c
===================================================================

arch/x86_64/kernel/traps.c +1 -1
@@ -908,7 +908,7 @@
 	set_intr_gate(0,&divide_error);
 	set_intr_gate_ist(1,&debug,DEBUG_STACK);
 	set_intr_gate_ist(2,&nmi,NMI_STACK);
-	set_intr_gate(3,&int3);
+	set_system_gate(3,&int3);
 	set_system_gate(4,&overflow);	/* int4-5 can be called from all */
 	set_system_gate(5,&bounds);
 	set_intr_gate(6,&invalid_op);

Index: linux/arch/x86_64/kernel/kprobes.c
===================================================================

arch/x86_64/kernel/kprobes.c +2 -0
@@ -297,6 +297,8 @@
 	struct die_args *args = (struct die_args *)data;
 	switch (val) {
 	case DIE_INT3:
+		if (args->regs->cs & 3)
+			return NOTIFY_DONE;
 		if (kprobe_handler(args->regs))
 			return NOTIFY_STOP;
 		break;
#4 lore raw

Hi Andi,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
arch/x86_64/kernel/traps.c +1 -1
-	set_intr_gate(3,&int3);
+	set_system_gate(3,&int3);
 	set_system_gate(4,&overflow);	/* int4-5 can be called from all */
 	set_system_gate(5,&bounds);
 	set_intr_gate(6,&invalid_op);

Index: linux/arch/x86_64/kernel/kprobes.c

This looks good to me. Andi do you see any thing that will cause premption
by moving int3 to system gate.

Quoted 9 lines
Quoted 9 lines

arch/x86_64/kernel/kprobes.c line 301

Quoted 9 lines

===================================================================

arch/x86_64/kernel/kprobes.c +2 -0
@@ -297,6 +297,8 @@
 	struct die_args *args = (struct die_args *)data;
 	switch (val) {
 	case DIE_INT3:
+		if (args->regs->cs & 3)
+			return NOTIFY_DONE;

This will prevent handling of userspace probes (privilege level 3). The kprobe_exception handler will return from here and registered user space probe handler won't be called.

Thanks
Prasanna

Signature · 5 lines
Prasanna S Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
<[email protected]>
#5 lore raw
Quoted 11 lines · Prasanna S Panchamukhi

Hi Andi,

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
arch/x86_64/kernel/traps.c +1 -1
-	set_intr_gate(3,&int3);
+	set_system_gate(3,&int3);
 	set_system_gate(4,&overflow);	/* int4-5 can be called from all */
 	set_system_gate(5,&bounds);
 	set_intr_gate(6,&invalid_op);

Index: linux/arch/x86_64/kernel/kprobes.c

This looks good to me. Andi do you see any thing that will cause premption
by moving int3 to system gate.

The only difference between an interrupt gate and a system gate is that a system gate can be called directly from user space using "int".

I don't see how that would affect preemption.

Quoted 14 lines
Quoted 10 lines
Quoted 10 lines

arch/x86_64/kernel/kprobes.c line 301

Quoted 10 lines

===================================================================

arch/x86_64/kernel/kprobes.c +2 -0
@@ -297,6 +297,8 @@
 	struct die_args *args = (struct die_args *)data;
 	switch (val) {
 	case DIE_INT3:
+		if (args->regs->cs & 3)
+			return NOTIFY_DONE;

This will prevent handling of userspace probes (privilege level 3). The kprobe_exception handler will return from here and registered user space probe handler won't be called.

It's equivalent to the previous code - previously the CPU would reject the int 3 call though and turn it into an GPF. If you prefer it I can remove it. But were user space probes ever tested? It doesn't look like it. If they're broken perhaps it would be better to disable it for now to prevent any unintended security issues.

-Andi