Skip to contentSkip to conversation

fs/jfs_logmgr: replace schedule_timeout() with

PATCH In review Nishanth Aravamudan 1 participant 1 message Jan 20, 2005

Subsystems (2)
Kernel janitors JFS filesystem
lore
Share & tools
lore

Nishanth Aravamudan

author
#0 lore raw

PATCH 6/40 fs/jfs_logmgr: replace schedule_timeout() with

Hi,

Please consider applying.

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. The current code uses TASK_INTERRUPTIBLE; however, it does not check for signals, so I do not think the change to msleep() is necessarily bad.

Signed-off-by Nishanth Aravamudan <[email protected]>
fs/jfs/jfs_logmgr.c +2 -2
@@ -67,6 +67,7 @@
 #include <linux/buffer_head.h>		/* for sync_blockdev() */
 #include <linux/bio.h>
 #include <linux/suspend.h>
+#include <linux/delay.h>
 #include "jfs_incore.h"
 #include "jfs_filsys.h"
 #include "jfs_metapage.h"

@@ -1612,8 +1613,7 @@ void jfs_flush_journal(struct jfs_log *l
 	 */
 	if ((!list_empty(&log->cqueue)) || !list_empty(&log->synclist)) {
 		for (i = 0; i < 800; i++) {	/* Too much? */
-			current->state = TASK_INTERRUPTIBLE;
-			schedule_timeout(HZ / 4);
+			msleep(250);
 			if (list_empty(&log->cqueue) &&
 			    list_empty(&log->synclist))
 				break;

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors