Skip to contentSkip to conversation

fs/transport: replace schedule_timeout() with

PATCH In review Nishanth Aravamudan 1 participant 1 message Jan 20, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 9/40 fs/transport: replace schedule_timeout() with

Hi,

Please consider applying.

Description: Use msleep() instead of schedule_timeout() to guarantee the task delays as expected. The current code uses TASK_INTERRUPTIBLE, but does not check for signals, so I believe the change to msleep() is acceptable.

fs/cifs/transport.c +2 -2
@@ -26,6 +26,7 @@
 #include <asm/uaccess.h>
 #include <asm/processor.h>
 #include <linux/mempool.h>
+#include <linux/delay.h>
 #include "cifspdu.h"
 #include "cifsglob.h"
 #include "cifsproto.h"
@@ -156,8 +157,7 @@ smb_send(struct socket *ssocket, struct 
 				rc = -EAGAIN;
 				break;
 			}
-			set_current_state(TASK_INTERRUPTIBLE);
-			schedule_timeout(HZ/2);
+			msleep(500);
 			continue;
 		}
 		if (rc < 0) 

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors