Skip to contentSkip to conversation

handle reada errors

PATCH In review Lars Marowsky-Bree 1 participant 2 messages Jan 21, 2005 Device mapper

lore
Share & tools
lore

Lars Marowsky-Bree

author
#0 lore raw

PATCH 1/1 handle reada errors

Silently ignore 'errors' for read ahead bios. They can fail in __make_request with a EWOULDBLOCK.

Signed-off-by Lars Marowsky-Bree <[email protected]>
drivers/md/dm-mpath.c +3 -1
Index: linux-2.6.5/drivers/md/dm-mpath.c
===================================================================
@@ -962,7 +975,9 @@ static int do_end_io(struct multipath *m
 	struct hw_handler *hwh = &m->hw_handler;
 	unsigned err_flags = MP_FAIL_PATH;	/* Default behavior */
 
-	if (!error)
+	/* Silently drop reada errors, since they don't indicate real IO
+	 * errors */
+	if (!error || bio_rw_ahead(bio))
 		return 0;	/* I/O complete */
 
 	spin_lock(&m->lock);

--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel

author
#1 lore raw
Quoted 2 lines · Lars Marowsky-Bree

Silently ignore 'errors' for read ahead bios. They can fail in __make_request with a EWOULDBLOCK.

Just noticed this patch seems to be specific to the SUSE kernel. Sorry about that, I keep losing track of what enhancements are already merged upstream and which aren't yet ;-)

Sincerely,
Lars Marowsky-Brée <[email protected]>

Signature · 8 lines
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business

--
dm-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/dm-devel