Skip to contentSkip to conversation

usb/kaweth: use

PATCH Oliver Neukum 2 participants 2 messages Jan 21, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Am Freitag, 21. Januar 2005 22:36 schrieb Nishanth Aravamudan:

Quoted 7 lines

Hi,

Please consider applying.

Description: Use wait_event_timeout() instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.

The macro seems essentially identical. If it compiles, what problems are you afraid of?

Regards
Oliver

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 11 lines · Oliver Neukum

Am Freitag, 21. Januar 2005 22:36 schrieb Nishanth Aravamudan:

Quoted 7 lines

Hi,

Please consider applying.

Description: Use wait_event_timeout() instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.

The macro seems essentially identical. If it compiles, what problems are you afraid of?

Oh I agree the code is identical, but if you look at the patch, I don't add to the queue before the if(status) check (which, if true, will remove from the wait-queue). I just wasn't sure if that part of the chane would be ok (intuitively it seemed so to me, but I'm not a wait-queue expert).

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors