Prevent NMI oopser
PATCH 1/1 Prevent NMI oopser
Marcello, Andrey
I believe this patch is wrong.
First, it prevent nothing: NMI watchdog is a signal that you wait too long with disabled interrupts. Your controller was not answered too long, obviously it is a hardware issue. Second, you could not call schedule() with io_request_lock spinlock taken.
You should unlock io_request_lock before msleep, like in latest versions of megaraid2 drivers.
Please fix it.
Thank you,
Vasily Averin, SWSoft Linux Kernel Team
# ChangeSet
# 2005/01/19 14:16:32-02:00 [email protected] # [PATCH] Prevent NMI oopser from triggering when megaraid2 waits # for abort/reset cmd completion
#
# > We should backport msleep() in 2.4.29-pre1.
#
# Ok, msleep() backported, but driver isn't fixed. This patch
# acceptable?
#
# Prevent NMI oopser kill kernel thread when megaraid2 driver waiting
# abort or reset command completion.
#
# Signed-off-by: Andrey Melnikov <[email protected]>
Quoted 8 lines · Vasily Averin
Marcello, Andrey
I believe this patch is wrong.
First, it prevent nothing: NMI watchdog is a signal that you wait too long with disabled interrupts. Your controller was not answered too long, obviously it is a hardware issue.
Second, you could not callschedule()withio_request_lockspinlock taken.
Quoted 4 lines
You should unlock
io_request_lockbefore msleep, like in latest versions of megaraid2 drivers.Please fix it.
OK, I've reverted it for now - waiting for megaraid2 update from LSI crew.