Skip to contentSkip to conversation

Re: [[email protected]: Re: Memory leak in 2.6.11-rc1?]

[email protected]: Re: Memory leak in 2.6.11-rc1? Bryce Harrington 2 participants 4 messages Jan 25, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Chris,

I applied the patch and reran the test on a RH 9.0 system. LTP is continuing past where it failed before, and processes are not getting killed, so I assume the OOM killer is no longer getting activated.

There is a new behavior, though. Now the test is hanging indefinitely on the nptl01 test. I am assuming that since it passed the spot that it had failed before, that this is an unrelated issue.

Bryce

Quoted 49 lines · Chris Wright

Any chance you could re-try with this patch applied?

----- Forwarded message from Linus Torvalds <[email protected]> -----

Date: Mon, 24 Jan 2005 14:35:47 -0800 (PST)
From: Linus Torvalds <[email protected]>
To: Andrew Morton <[email protected]>
cc: Jens Axboe <[email protected]>, [email protected], [email protected],
[email protected], [email protected]
Subject: Re: Memory leak in 2.6.11-rc1?

Quoted 2 lines · Andrew Morton

Would indicate that the new pipe code is leaking.

Duh. It's the pipe merging.

Linus

----

fs/pipe.c +2 -3
@@ -630,13 +630,13 @@
 	struct pipe_inode_info *info = inode->i_pipe;
 
 	inode->i_pipe = NULL;
-	if (info->tmp_page)
-		__free_page(info->tmp_page);
 	for (i = 0; i < PIPE_BUFFERS; i++) {
 		struct pipe_buffer *buf = info->bufs + i;
 		if (buf->ops)
 			buf->ops->release(info, buf);
 	}
+	if (info->tmp_page)
+		__free_page(info->tmp_page);
 	kfree(info);
 }
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

----- End forwarded message -----

#2 lore raw
Quoted 4 lines · Bryce Harrington

There is a new behavior, though. Now the test is hanging indefinitely
on the nptl01 test. I am assuming that since it passed the spot that it had failed before, that this is an unrelated issue.

I'm finding that nptl01 somtimes gets stuck and sometimes works OK. Try running it by hand a few times.

It could be an application bug or a kernel bug.

#3 lore raw
Quoted 10 lines · Andrew Morton
Quoted 4 lines · Bryce Harrington

There is a new behavior, though. Now the test is hanging indefinitely
on the nptl01 test. I am assuming that since it passed the spot that it had failed before, that this is an unrelated issue.

I'm finding that nptl01 somtimes gets stuck and sometimes works OK. Try running it by hand a few times.

It could be an application bug or a kernel bug.

Okay, so it doesn't sound like anything to be worried about.

Thanks,
Bryce

#4 lore raw
Quoted 8 lines · Bryce Harrington
Quoted 6 lines · Andrew Morton
Quoted 4 lines · Bryce Harrington

There is a new behavior, though. Now the test is hanging indefinitely
on the nptl01 test. I am assuming that since it passed the spot that it had failed before, that this is an unrelated issue.

Quoted 7 lines
Quoted 4 lines

I'm finding that nptl01 somtimes gets stuck and sometimes works OK. Try running it by hand a few times.

It could be an application bug or a kernel bug.

Okay, so it doesn't sound like anything to be worried about.

Well no. If we're sure that kernel changes caused this new behaviour then that's a problem.