isdn/isdn_common: replace
PATCH 21/34 isdn/isdn_common: replace
Hi,
Please consider applying.
Description: Use wait_event() instead of the deprecated interruptible_sleep_on(). Current code does not check for signals, so interruptible seems unnecessary. Patch is compile-tested.
drivers/isdn/i4l/isdn_common.c +3 -2
@@ -19,6 +19,7 @@#include <linux/vmalloc.h> #include <linux/isdn.h> #include <linux/smp_lock.h> +#include <linux/wait.h> #include "isdn_common.h" #include "isdn_tty.h" #include "isdn_net.h"
@@ -1066,8 +1067,8 @@ isdn_write(struct file *file, const char goto out; } chidx =isdn_minor2chan (minor); -while (isdn_writebuf_stub (drvidx, chidx, buf, count) != count) -interruptible_sleep_on (&dev->drv[drvidx]->snd_waitq[chidx]); +wait_event (dev->drv[drvidx]->snd_waitq[chidx], + (isdn_writebuf_stub (drvidx, chidx, buf, count) == count)); retval = count; goto out; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
PATCH 21/34 isdn/isdn_common: replace
Hi,
Incorrect subject line, sorry.
Please consider applying.
Description: Use wait_event() instead of the deprecated interruptible_sleep_on(). Current code does not check for signals, so interruptible seems unnecessary. Patch is compile-tested.
drivers/isdn/i4l/isdn_common.c +3 -2
@@ -19,6 +19,7 @@#include <linux/vmalloc.h> #include <linux/isdn.h> #include <linux/smp_lock.h> +#include <linux/wait.h> #include "isdn_common.h" #include "isdn_tty.h" #include "isdn_net.h"
@@ -1066,8 +1067,8 @@ isdn_write(struct file *file, const char goto out; } chidx =isdn_minor2chan (minor); -while (isdn_writebuf_stub (drvidx, chidx, buf, count) != count) -interruptible_sleep_on (&dev->drv[drvidx]->snd_waitq[chidx]); +wait_event (dev->drv[drvidx]->snd_waitq[chidx], + (isdn_writebuf_stub (drvidx, chidx, buf, count) == count)); retval = count; goto out; }
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors