Skip to contentSkip to conversation

therm_adt746x: smooth fan

PATCH In review Jorge Bernal 3 participants 3 messages Jan 26, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 therm_adt746x: smooth fan

Hi all!

This patchs allows a smoother fan speed switching with therm_adt746x. Instead of setting 0 or 128, it scales speed according to temperature.

It would be even better if I'd have more precise temp data, but I'm not sure if it's even supported by the chip.

drivers/macintosh/therm_adt746x.c 2005-01-26 03:10:36.925343344 +0100 renamed from drivers/macintosh/therm_adt746x.c 2005-01-26 02:50:31.941528728 +0100 +4 -1
@@ -272,7 +272,10 @@
       printk(KERN_INFO "adt746x: Limit exceeded by %d, setting speed to specified for %s.\n",
        var, fan_number?"GPU":"CPU");     
      th->overriding[fan_number] = 0;
-     write_fan_speed(th, fan_speed, fan_number);
+     if ((var > 2) && (var < 8))
+      write_fan_speed(th, (int)(fan_speed * var / 6), fan_number);
+     else
+      write_fan_speed(th, fan_speed, fan_number);
      started = 1;
     } else if (var < -1) {
      /
maintainer
#1 lore raw
Quoted 2 lines

This patchs allows a smoother fan speed switching with therm_adt746x. Instead of setting 0 or 128, it scales speed according to temperature.

Thanks, but you'd have saved some of your time if you had checked 2.6.10: I implemented such a system, it's in since 2.6.10 :)

Quoted 2 lines

It would be even better if I'd have more precise temp data, but I'm not sure if it's even supported by the chip.

It's not possible, iirc.

Also, it's better to Cc: the maintainer of a module when submitting patches. I'm not subscribed to lkml currently, and would have missed your mail if I didn't get it from a friend.

Signature · 1 line
Colin
#2 lore raw
Quoted 6 lines · Colin Leroy
Quoted 2 lines

This patchs allows a smoother fan speed switching with therm_adt746x. Instead of setting 0 or 128, it scales speed according to temperature.

Thanks, but you'd have saved some of your time if you had checked 2.6.10: I implemented such a system, it's in since 2.6.10 :)

doh! no problem at all, it didn't took me much time.

I guess I'll try in 2.6.11, since hibernation does not work very well with 2.6.10 in my ibook.

Quoted 8 lines
Quoted 2 lines

It would be even better if I'd have more precise temp data, but I'm not sure if it's even supported by the chip.

It's not possible, iirc.

Also, it's better to Cc: the maintainer of a module when submitting patches. I'm not subscribed to lkml currently, and would have missed your mail if I didn't get it from a friend.

I'll note for the next time, thanks :)

Signature · 7 lines
Jorge Bernal "Koke"
Personal:  [email protected]
Jabber:  [email protected]
Blog:  http://www.amedias.org/koke/

"Computer Science is no more about computers than astronomy is about 
telescopes." - Edsger Dijkstra