Skip to contentSkip to conversation

unexport get_wchan

RFC PATCH In review Adrian Bunk 2 participants 3 messages Jan 31, 2005 – Oct 31, 2005

Subsystems (4)
Arm (32-bit) MIPS m68k architecture Alpha port
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

RFC PATCH 1/1 unexport get_wchan

The only user of get_wchan I was able to find is the proc fs - and proc can't be built modular.

Is the patch below to remove the export of get_wchan correct or did I oversee something?

---

 arch/alpha/kernel/alpha_ksyms.c    |    2 --
 arch/arm/kernel/process.c          |    1 -
 arch/arm26/kernel/armksyms.c       |    2 --
 arch/frv/kernel/frv_ksyms.c        |    2 --
 arch/h8300/kernel/h8300_ksyms.c    |    2 --
 arch/i386/kernel/i386_ksyms.c      |    2 --
 arch/m68k/kernel/m68k_ksyms.c      |    1 -
 arch/m68knommu/kernel/m68k_ksyms.c |    2 --
 arch/mips/kernel/process.c         |    1 -
 arch/ppc/kernel/ppc_ksyms.c        |    1 -
 arch/ppc64/kernel/ppc_ksyms.c      |    1 -
 arch/x86_64/kernel/x8664_ksyms.c   |    2 --
 12 files changed, 19 deletions(-)
arch/i386/kernel/i386_ksyms.c renamed from arch/i386/kernel/i386_ksyms.c.old +0 -2
@@ -159,8 +159,6 @@
 EXPORT_SYMBOL(screen_info);
 #endif
 
-EXPORT_SYMBOL(get_wchan);
-
 EXPORT_SYMBOL(rtc_lock);
 
 EXPORT_SYMBOL_GPL(set_nmi_callback);
arch/arm/kernel/process.c renamed from arch/arm/kernel/process.c.old +0 -1
@@ -461,4 +461,3 @@
 	} while (count ++ < 16);
 	return 0;
 }
-EXPORT_SYMBOL(get_wchan);
arch/ppc/kernel/ppc_ksyms.c renamed from arch/ppc/kernel/ppc_ksyms.c.old +0 -1
@@ -288,7 +288,6 @@
 EXPORT_SYMBOL(timer_interrupt);
 EXPORT_SYMBOL(irq_desc);
 EXPORT_SYMBOL(tb_ticks_per_jiffy);
-EXPORT_SYMBOL(get_wchan);
 EXPORT_SYMBOL(console_drivers);
 #ifdef CONFIG_XMON
 EXPORT_SYMBOL(xmon);
arch/mips/kernel/process.c renamed from arch/mips/kernel/process.c.old +0 -1
@@ -361,4 +361,3 @@
 	return pc;
 }
 
-EXPORT_SYMBOL(get_wchan);
arch/m68knommu/kernel/m68k_ksyms.c renamed from arch/m68knommu/kernel/m68k_ksyms.c.old +0 -2
@@ -60,8 +60,6 @@
 EXPORT_SYMBOL(__down_failed_trylock);
 EXPORT_SYMBOL(__up_wakeup);
 
-EXPORT_SYMBOL(get_wchan);
-
 /*
  * libgcc functions - functions that are used internally by the
  * compiler...  (prototypes are not correct though, but that
arch/arm26/kernel/armksyms.c renamed from arch/arm26/kernel/armksyms.c.old +0 -2
@@ -213,8 +213,6 @@
 EXPORT_SYMBOL(sys_exit);
 EXPORT_SYMBOL(sys_wait4);
 
-EXPORT_SYMBOL(get_wchan);
-
 #ifdef CONFIG_PREEMPT
 EXPORT_SYMBOL(kernel_flag);
 #endif
arch/m68k/kernel/m68k_ksyms.c renamed from arch/m68k/kernel/m68k_ksyms.c.old +0 -1
@@ -85,4 +85,3 @@
 EXPORT_SYMBOL(__down_failed_trylock);
 EXPORT_SYMBOL(__up_wakeup);
 
-EXPORT_SYMBOL(get_wchan);
arch/alpha/kernel/alpha_ksyms.c renamed from arch/alpha/kernel/alpha_ksyms.c.old +0 -2
@@ -228,8 +228,6 @@
 EXPORT_SYMBOL(memset);
 EXPORT_SYMBOL(memchr);
 
-EXPORT_SYMBOL(get_wchan);
-
 #ifdef CONFIG_ALPHA_IRONGATE
 EXPORT_SYMBOL(irongate_ioremap);
 EXPORT_SYMBOL(irongate_iounmap);
arch/ppc64/kernel/ppc_ksyms.c renamed from arch/ppc64/kernel/ppc_ksyms.c.old +0 -1
@@ -151,7 +151,6 @@
 
 EXPORT_SYMBOL(timer_interrupt);
 EXPORT_SYMBOL(irq_desc);
-EXPORT_SYMBOL(get_wchan);
 EXPORT_SYMBOL(console_drivers);
 
 EXPORT_SYMBOL(tb_ticks_per_usec);
arch/h8300/kernel/h8300_ksyms.c renamed from arch/h8300/kernel/h8300_ksyms.c.old +0 -2
@@ -57,8 +57,6 @@
 EXPORT_SYMBOL(memscan);
 EXPORT_SYMBOL(memmove);
 
-EXPORT_SYMBOL(get_wchan);
-
 /*
  * libgcc functions - functions that are used internally by the
  * compiler...  (prototypes are not correct though, but that
arch/x86_64/kernel/x8664_ksyms.c renamed from arch/x86_64/kernel/x8664_ksyms.c.old +0 -2
@@ -126,8 +126,6 @@
 EXPORT_SYMBOL(screen_info);
 #endif
 
-EXPORT_SYMBOL(get_wchan);
-
 EXPORT_SYMBOL(rtc_lock);
 
 EXPORT_SYMBOL_GPL(set_nmi_callback);
arch/frv/kernel/frv_ksyms.c renamed from arch/frv/kernel/frv_ksyms.c.old +0 -2
@@ -73,8 +73,6 @@
 EXPORT_SYMBOL(memmove);
 EXPORT_SYMBOL(strtok);
 
-EXPORT_SYMBOL(get_wchan);
-
 #ifdef CONFIG_FRV_OUTOFLINE_ATOMIC_OPS
 EXPORT_SYMBOL(atomic_test_and_ANDNOT_mask);
 EXPORT_SYMBOL(atomic_test_and_OR_mask);
#1 lore raw
Quoted 5 lines · Adrian Bunk

The only user of get_wchan I was able to find is the proc fs - and proc can't be built modular.

Is the patch below to remove the export of get_wchan correct or did I oversee something?

I have an oprofile patch queued up which uses get_wchan. Oprofile can be built modular.

Greg.

Signature · 2 lines
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
author
#2 lore raw
Quoted 9 lines · Greg Banks
Quoted 5 lines · Adrian Bunk

The only user of get_wchan I was able to find is the proc fs - and proc can't be built modular.

Is the patch below to remove the export of get_wchan correct or did I oversee something?

I have an oprofile patch queued up which uses get_wchan. Oprofile can be built modular.

What happened with this patch that would use get_wchan?

Quoted 1 line

Greg.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed