Skip to contentSkip to conversation

move dp83840.h to Documentation/

PATCH In review Adrian Bunk 4 participants 6 messages Jan 31, 2005 – Feb 2, 2005

Subsystems (3)
Networking Network drivers Documentation
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 move dp83840.h to Documentation/

dp83840.h is included once but none of the definitions it contains is actually used.

Ralf Baechle wants that it stays as documentation, so this patch moves it under Documentation/ .

Signed-off-by Adrian Bunk <[email protected]>

---

 Documentation/networking/00-INDEX    |    2 +
 Documentation/networking/dp83840.txt |   41 +++++++++++++++++++++++++++
 drivers/net/ioc3-eth.c               |    1 
 include/linux/dp83840.h              |   41 ---------------------------
 4 files changed, 43 insertions(+), 42 deletions(-)

This patch was already sent on:
- 29 Nov 2004

drivers/net/ioc3-eth.c renamed from drivers/net/ioc3-eth.c.old +0 -1
@@ -56,7 +56,6 @@
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/skbuff.h>
-#include <linux/dp83840.h>
 #include <net/ip.h>
 
 #include <asm/byteorder.h>
include/linux/dp83840.h deleted +0 -41

41 lines not on this page · raw message

Documentation/networking/dp83840.txt new file +41 -0

41 lines not on this page · raw message

Documentation/networking/00-INDEX renamed from Documentation/networking/00-INDEX.old +2 -0
@@ -42,6 +42,8 @@
 	- the Digi International RightSwitch SE-X Ethernet driver
 dmfe.txt
 	- info on the Davicom DM9102(A)/DM9132/DM9801 fast ethernet driver.
+dp83840.txt
+	- the former dp83840.h
 e100.txt
 	- info on Intel's EtherExpress PRO/100 line of 10/100 boards
 e1000.txt
maintainer
#1 lore raw
Quoted 5 lines · On Tue, 1 Feb 2005 00:41:58 +0100 Adrian Bunk <[email protected]> wrote:

dp83840.h is included once but none of the definitions it contains is actually used.

Ralf Baechle wants that it stays as documentation, so this patch moves it under Documentation/ .

No, let's kill this thing altogether. The only driver in the world using the CSCONFIG_* defines in there is the sunhme driver and it defines it's own macros in drivers/net/sunhme.h This header is more than useless these days.

The header still exists in older trees and the revision history. So people can still get to it there.

#2 lore raw
Quoted 10 lines · David S. Miller
Quoted 4 lines · On Tue, 1 Feb 2005 00:41:58 +0100 Adrian Bunk <[email protected]> wrote:

dp83840.h is included once but none of the definitions it contains is actually used.

Ralf Baechle wants that it stays as documentation, so this patch moves it under Documentation/ .

Quoted 7 lines

No, let's kill this thing altogether. The only driver in the world using the CSCONFIG_* defines in there is the sunhme driver and it defines it's own macros in drivers/net/sunhme.h This header is more than useless these days.

The header still exists in older trees and the revision history. So people can still get to it there.

agreed

author
#3 lore raw

PATCH 1/1 remove dp83840.h

In reply to David S. Miller
Quoted 9 lines · David S. Miller
Quoted 5 lines · On Tue, 1 Feb 2005 00:41:58 +0100 Adrian Bunk <[email protected]> wrote:

dp83840.h is included once but none of the definitions it contains is actually used.

Ralf Baechle wants that it stays as documentation, so this patch moves it under Documentation/ .

Quoted 7 lines

No, let's kill this thing altogether. The only driver in the world using the CSCONFIG_* defines in there is the sunhme driver and it defines it's own macros in drivers/net/sunhme.h This header is more than useless these days.

The header still exists in older trees and the revision history. So people can still get to it there.

OK, patch below

cu
Adrian

<-- snip -->

dp83840.h is included once but none of the definitions it contains is actually used.

Signed-off-by Adrian Bunk <[email protected]>

---

 drivers/net/ioc3-eth.c               |    1 
 include/linux/dp83840.h              |   41 ---------------------------
 2 files changed, 42 deletions(-)
drivers/net/ioc3-eth.c renamed from drivers/net/ioc3-eth.c.old +0 -1
@@ -56,7 +56,6 @@
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/skbuff.h>
-#include <linux/dp83840.h>
 #include <net/ip.h>
 
 #include <asm/byteorder.h>
include/linux/dp83840.h deleted +0 -41

41 lines not on this page · raw message

#5 lore raw
In reply to Adrian Bunk
Quoted 6 lines · Adrian Bunk

dp83840.h is included once but none of the definitions it contains is actually used.

Ralf Baechle wants that it stays as documentation, so this patch moves it under Documentation/ .

Under Documentation is certainly not the right place for a piece of code, so let's do it as David says.

Ralf