usb/kaweth: use wait_event_timeout()
Greg KH
AppliedQuoted 24 lines · Nishanth Aravamudan
Quoted 11 lines · Greg KH
Quoted 10 lines · Nishanth Aravamudan
Quoted 9 lines · Greg KH
Quoted 7 lines · Nishanth Aravamudan
Hi,
Please consider applying.
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Please at least compile your patches to make sure they build. This one does not :(
I'm not seeing a build error here; what errors are coming up for you?
Don't remember anymore, as I reverted the patch already...
I think it was a {} matching issue like your other patches.
You are right. I had actually fixed this, but didn't mail the updated diff. Sorry about that, Greg.
Quoted 7 lines
Please consider the following which builds cleanly.
Description: Use
wait_event_timeout()instead of custom wait-queue code. Remove now unused variables. I changed the code to only add to the wait-queue if necessary, but I'm not sure if this is correct.Signed-off-by Nishanth Aravamudan <[email protected]>
Applied, thanks.
greg k-h
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors