Skip to contentSkip to conversation

i386/mach-default/topology.c: make cpu_devices static

PATCH In review Adrian Bunk 2 participants 2 messages Jan 31, 2005 – Feb 2, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386/mach-default/topology.c: make cpu_devices static

This patch makes a needlessly global struct static.

---

 arch/i386/mach-default/topology.c |    2 +-
 include/asm-i386/cpu.h            |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

This patch was already sent on:
- 16 Jan 2005

include/asm-i386/cpu.h renamed from include/asm-i386/cpu.h.old +0 -1
@@ -12,7 +12,6 @@
 struct i386_cpu {
 	struct cpu cpu;
 };
-extern struct i386_cpu cpu_devices[NR_CPUS];
 extern int arch_register_cpu(int num);
 #ifdef CONFIG_HOTPLUG_CPU
 extern void arch_unregister_cpu(int);
arch/i386/mach-default/topology.c renamed from arch/i386/mach-default/topology.c.old +1 -1
@@ -30,7 +30,7 @@
 #include <linux/nodemask.h>
 #include <asm/cpu.h>
 
-struct i386_cpu cpu_devices[NR_CPUS];
+static struct i386_cpu cpu_devices[NR_CPUS];
 
 int arch_register_cpu(int num){
 	struct node *parent = NULL;
Acked-by on v1 1/1
#1 lore raw

Looks good to me!

Quoted 44 lines · Adrian Bunk

This patch makes a needlessly global struct static.

---

arch/i386/mach-default/topology.c |    2 +-
include/asm-i386/cpu.h            |    1 -
2 files changed, 1 insertion(+), 2 deletions(-)

This patch was already sent on:
- 16 Jan 2005

include/asm-i386/cpu.h renamed from include/asm-i386/cpu.h.old +0 -1
@@ -12,7 +12,6 @@
 struct i386_cpu {
 	struct cpu cpu;
 };
-extern struct i386_cpu cpu_devices[NR_CPUS];
 extern int arch_register_cpu(int num);
 #ifdef CONFIG_HOTPLUG_CPU
 extern void arch_unregister_cpu(int);
arch/i386/mach-default/topology.c renamed from arch/i386/mach-default/topology.c.old +1 -2
@@ -30,7 +30,7 @@
 #include <linux/nodemask.h>
 #include <asm/cpu.h>
 
-struct i386_cpu cpu_devices[NR_CPUS];
+static struct i386_cpu cpu_devices[NR_CPUS];
 
 int arch_register_cpu(int num){
 	struct node *parent = NULL;
 
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/