PCI: add PCI Express Port Bus Driver subsystem
Quoted 9 lines · Greg KH
Quoted 9 lines
Quoted 8 lines
That would be great, but it doesn't show up that way on my box. All of
the portX devices are in/sys/devices/which is what I don't think you
want. I would love for them to have the parent of thepci_devstructure
:)
Quoted 7 lines
Quoted 2 lines
Agree. Thanks for your inputs. The patch below include the changes based on your previous post.
Hm, that seems like a pretty big patch just to add a pointer to a parent device :)
What really does this patch do? What does the sysfs tree now look like?
Before changes:
The patch makes the parent of the device pointing to the pci_dev structure. The parents portX devices are in /sys/devices which should be removed based on your suggestions. Below is /sys/devices before any changes made.
/sys/devices
| __ ide0 | __ pci0000:00 | __ pnp0 | __ port1 | | | __ port1.00 | | | __ port1.01 | . | . | . | __ port2 | __ port3 | __ system
After changes:
The parents portX devices are no longer necessary because port1.00 and port1.01 devices shoud have the parent of the pci_dev structure (based on your suggestion). The patch does the following changes:
- remove code creating and handling the parent portX devices.
- rename portX.YZ to pcieYZ (for example port1.00 renamed to pcie00) since portX is no longer needed.
- make pcieYZ have the parent of the pci_dev structure.
Below is /sys/devices after changes made to the patch.
/sys/devices
| __ ide0 | __ pci0000:00 | | | __ 0000:00:00.0 | | | __ 0000:00:04.0 | | | | . __ class | . | | . __ pcie00 | | | __ pcie01 | . | . | . | __ platform | __ pnp0 | __ system
Please let me know what you think of the changes.
Thanks,
Long
Quoted 87 lines · long
Quoted 9 lines · Greg KH
Quoted 9 lines
Quoted 8 lines
That would be great, but it doesn't show up that way on my box. All of
the portX devices are in/sys/devices/which is what I don't think you
want. I would love for them to have the parent of thepci_devstructure
:)Quoted 7 lines
Quoted 2 lines
Agree. Thanks for your inputs. The patch below include the changes based on your previous post.
Hm, that seems like a pretty big patch just to add a pointer to a parent device :)
What really does this patch do? What does the sysfs tree now look like?
Before changes:
The patch makes the parent of the device pointing to the
pci_devstructure. The parents portX devices are in/sys/deviceswhich should be removed based on your suggestions. Below is/sys/devicesbefore any changes made.
/sys/devices| __ ide0 | __ pci0000:00 | __ pnp0 | __ port1 | | | __ port1.00 | | | __ port1.01 | . | . | . | __ port2 | __ port3 | __ systemAfter changes:
The parents portX devices are no longer necessary because port1.00 and port1.01 devices shoud have the parent of the
pci_devstructure (based on your suggestion). The patch does the following changes:- remove code creating and handling the parent portX devices.
- rename portX.YZ to pcieYZ (for example port1.00 renamed to pcie00) since portX is no longer needed.
- make pcieYZ have the parent of thepci_devstructure.Below is
/sys/devicesafter changes made to the patch.
/sys/devices| __ ide0 | __ pci0000:00 | | | __ 0000:00:00.0 | | | __ 0000:00:04.0 | | | | . __ class | . | | . __ pcie00 | | | __ pcie01 | . | . | . | __ platform | __ pnp0 | __ system
Quoted 1 line
Please let me know what you think of the changes.
Ok, that makes more sense now. I've applied your patch, thanks.
greg k-h