Skip to contentSkip to conversation

Fix Kconfig for Broadcom SWARM

PATCH In review Manish Lachwani 3 participants 7 messages Feb 1, 2005 – Feb 3, 2005 MIPS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix Kconfig for Broadcom SWARM

Hi Ralf,

Attached patch adds necessary options for Broadcom SWARM.

Thanks
Manish Lachwani

arch/mips/Kconfig +2 -0
Index: linux/arch/mips/Kconfig
===================================================================
@@ -498,6 +498,8 @@
 	select SWAP_IO_SPACE
 	select SYS_SUPPORTS_BIG_ENDIAN
 	select SYS_SUPPORTS_LITTLE_ENDIAN
+	select SIBYTE_CFE
+	select SIBYTE_HAS_LDT
 
 config SIBYTE_SENTOSA
 	bool "Support for Sibyte BCM91250E-Sentosa"
#1 lore raw
Quoted 1 line · Manish Lachwani

Attached patch adds necessary options for Broadcom SWARM.

What is it supposed to do?

Maciej

#2 lore raw
Quoted 4 lines · Maciej W. Rozycki

On Tue, 1 Feb 2005, Manish Lachwani wrote:

Quoted 9 lines
Quoted 3 lines

Attached patch adds necessary options for Broadcom SWARM.

What is it supposed to do?

Maciej

libs-$(CONFIG_SIBYTE_CFE) += arch/mips/sibyte/cfe/

in arch/mips/Makefile

So, without the above, contents of arch/mips/sibyte/cfe/ are not compiled.

SIBYTE_HAS_LDT is needed for the LDT specific stuff in arch/mips/pci/pci-sb1250.c

Btw, there are other issues as well. More options need to be defined to compile in the serial driver, ethernet driver and to compile for a PASS 2 CPU. For example, the ethernet driver drivers/net/sb1250-mac.c compiles only if SIBYTE_SB1xxx_SOC is defined. And SIBYTE_SB1xxx_SOC no longer exists in arch/mips/Kconfig.

Thanks
Manish Lachwani

#3 lore raw
Quoted 8 lines · Manish Lachwani

libs-$(CONFIG_SIBYTE_CFE) += arch/mips/sibyte/cfe/

in arch/mips/Makefile

So, without the above, contents of arch/mips/sibyte/cfe/ are not compiled.

SIBYTE_HAS_LDT is needed for the LDT specific stuff in arch/mips/pci/pci-sb1250.c

Both options are taken care of in arch/mips/sibyte/Kconfig, thus any fix
should be sought there.

Quoted 2 lines

Btw, there are other issues as well. More options need to be defined to compile in the serial driver, ethernet driver and to compile for a PASS 2 CPU.

Likewise.

Quoted 3 lines

For example, the ethernet driver drivers/net/sb1250-mac.c compiles only if SIBYTE_SB1xxx_SOC is defined. And SIBYTE_SB1xxx_SOC no longer exists in arch/mips/Kconfig.

This one is missing indeed.

I'll have a look at how to get the mess resolved.

Maciej

#5 lore raw
Quoted 4 lines · Ralf Baechle

On Tue, Feb 01, 2005 at 12:28:35PM -0800, Manish Lachwani wrote:

Quoted 9 lines
Quoted 3 lines

Attached patch adds necessary options for Broadcom SWARM.

And forgets about all other Sibyte boards ...

Ralf

The problem is that SIBYTE_SB1xxx_SOC is undefined. We need a small change in arch/mips/sibyte/Kconfig:

config SIBYTE_SB1xxx_SOC
bool "Support for Broadcom BCM1xxx SOCs "

Since the ethernet driver, the serial driver and the CFE depend on this option to be selected else they wont be compiled in.

Thanks
Manish Lachwani

#6 lore raw
Quoted 8 lines · Manish Lachwani

The problem is that SIBYTE_SB1xxx_SOC is undefined. We need a small change in arch/mips/sibyte/Kconfig:

config SIBYTE_SB1xxx_SOC
bool "Support for Broadcom BCM1xxx SOCs "

Since the ethernet driver, the serial driver and the CFE depend on this option to be selected else they wont be compiled in.

The fix for this is already in CVS since a few hours.

Ralf