Skip to contentSkip to conversation

prism54: use initialized current_time in debug_code

PATCH New Alexey Dobriyan 1 participant 1 message Feb 2, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 prism54: use initialized current_time in debug_code

Otherwise gcc 4 complains:

drivers/net/wireless/prism54/isl_38xx.c: In function ‘isl38xx_trigger_device’:
drivers/net/wireless/prism54/isl_38xx.c:131: warning: ‘current_time.tv_sec’ is used uninitialized in this function drivers/net/wireless/prism54/isl_38xx.c:131: warning: ‘current_time.tv_usec’ is used uninitialized in this function

drivers/net/wireless/prism54/isl_38xx.c renamed from drivers/net/wireless/prism54/isl_38xx.c.orig +6 -2
@@ -112,7 +112,9 @@ isl38xx_handle_wakeup(isl38xx_control_bl
 void
 isl38xx_trigger_device(int asleep, void __iomem *device_base)
 {
+#if VERBOSE > SHOW_ERROR_MESSAGES
 	struct timeval current_time;
+#endif
 	u32 reg, counter = 0;
 
 #if VERBOSE > SHOW_ERROR_MESSAGES
@@ -126,11 +128,10 @@ isl38xx_trigger_device(int asleep, void 
 		do_gettimeofday(&current_time);
 		DEBUG(SHOW_TRACING, "%08li.%08li Device wakeup triggered\n",
 		      current_time.tv_sec, current_time.tv_usec);
-#endif
-
 		DEBUG(SHOW_TRACING, "%08li.%08li Device register read %08x\n",
 		      current_time.tv_sec, current_time.tv_usec,
 		      readl(device_base + ISL38XX_CTRL_STAT_REG));
+#endif
 		udelay(ISL38XX_WRITEIO_DELAY);
 
 		reg = readl(device_base + ISL38XX_INT_IDENT_REG);
@@ -148,10 +149,13 @@ isl38xx_trigger_device(int asleep, void 
 				counter++;
 			}
 
+#if VERBOSE > SHOW_ERROR_MESSAGES
+			do_gettimeofday(&current_time);
 			DEBUG(SHOW_TRACING,
 			      "%08li.%08li Device register read %08x\n",
 			      current_time.tv_sec, current_time.tv_usec,
 			      readl(device_base + ISL38XX_CTRL_STAT_REG));
+#endif
 			udelay(ISL38XX_WRITEIO_DELAY);
 
 #if VERBOSE > SHOW_ERROR_MESSAGES