char/lp: remove interruptible_sleep_on_timeout()
Subsystems (2)
PATCH 1/20 char/lp: remove interruptible_sleep_on_timeout()
Hello,
Please consider applying.
Description: Replace deprecated interruptible_sleep_on_timeout() function calls with direct wait-queue usage. There may be an existing problem with this driver, as I am not finding any wake_up_interruptible() callers for the waitq. Patch is compile-tested.
Signed-off-by Nishanth Aravamudan <[email protected]>
drivers/char/lp.c +11 -5
@@ -127,6 +127,7 @@#include <linux/poll.h> #include <linux/console.h> #include <linux/device.h> +#include <linux/wait.h> #include <linux/parport.h> #undef LP_STATS
@@ -218,6 +219,7 @@ static int lp_reset(int minor)static void lp_error (int minor) { +DEFINE_WAIT (wait);int polling;if (LP_F (minor) &LP_ABORT )
@@ -225,8 +227,9 @@ static void lp_error (int minor) polling = lp_table[minor].dev->port->irq ==PARPORT_IRQ_NONE ;if (polling)lp_release_parport (&lp_table[minor]); -interruptible_sleep_on_timeout (&lp_table[minor].waitq, -LP_TIMEOUT_POLLED ); +prepare_to_wait (&lp_table[minor].waitq, &wait,TASK_INTERRUPTIBLE ); +schedule_timeout (LP_TIMEOUT_POLLED ); +finish_wait (&lp_table[minor].waitq, &wait);if (polling)lp_claim_parport_or_block (&lp_table[minor]);else parport_yield_blocking (lp_table[minor].dev); }
@@ -410,6 +413,7 @@ static ssize_t lp_write(struct file * fistatic ssize_t lp_read (struct file * file,char __user * buf,size_t count,loff_t *ppos) { +DEFINE_WAIT (wait);unsigned int minor=iminor (file->f_dentry->d_inode);struct parport *port = lp_table[minor].dev->port;ssize_t retval =0 ;
@@ -458,9 +462,11 @@ static ssize_t lp_read(struct file * fil retval = -EIO ; goto out; } - }else -interruptible_sleep_on_timeout (&lp_table[minor].waitq, -LP_TIMEOUT_POLLED ); + }else { +prepare_to_wait (&lp_table[minor].waitq, &wait,TASK_INTERRUPTIBLE ); +schedule_timeout (LP_TIMEOUT_POLLED ); +finish_wait (&lp_table[minor].waitq, &wait); + }if (signal_pending (current)) { retval = -ERESTARTSYS ;
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors