Skip to contentSkip to conversation

add missing space to printk in ide_allocate_dma_engine

PATCH Applied Olaf Hering 2 participants 6 messages Feb 2, 2005 – Feb 3, 2005 libata

lore
Share & tools
lore

Olaf Hering

author
#0 lore raw

PATCH 1/1 add missing space to printk in ide_allocate_dma_engine

a space is missing.

drivers/ide/ide-dma.c +1 -1
diff -p -purN linux-2.6.11-rc2.orig/drivers/ide/ide-dma.c linux-2.6.11-rc2/drivers/ide/ide-dma.c
@@ -829,7 +829,7 @@ int ide_allocate_dma_engine (ide_hwif_t 
 	if (hwif->dmatable_cpu)
 		return 0;
 
-	printk(KERN_ERR "%s: -- Error, unable to allocate%s DMA table(s).\n",
+	printk(KERN_ERR "%s: -- Error, unable to allocate %s DMA table(s).\n",
 		(hwif->dmatable_cpu == NULL) ? " CPU" : "",
 		hwif->cds->name);
author
#3 lore raw
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Bartlomiej Zolnierkiewicz

applied

and reversed, missing space is here: " CPU"

This was my oops:

Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
W82C105: IDE controller at PCI slot 0000:00:03.1
W82C105: chipset revision 5
W82C105: 100% native mode on irq 102

    ide0: BM-DMA at 0xf040-0xf047<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
    ide1: BM-DMA at 0xf048-0xf04f<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
hda: HL-DT-ST CD-ROM GCR-8480B, ATAPI CD/DVD-ROM drive
Oops: Kernel access of bad area, sig: 11 [#1]

SMP NR_CPUS=128 NUMA PSERIES

#4 lore raw
Quoted 15 lines · Olaf Hering
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Bartlomiej Zolnierkiewicz

applied

and reversed, missing space is here: " CPU"

This was my oops:

Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
W82C105: IDE controller at PCI slot 0000:00:03.1
W82C105: chipset revision 5
W82C105: 100% native mode on irq 102

Quoted 5 lines
    ide0: BM-DMA at 0xf040-0xf047<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
    ide1: BM-DMA at 0xf048-0xf04f<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
hda: HL-DT-ST CD-ROM GCR-8480B, ATAPI CD/DVD-ROM drive
Oops: Kernel access of bad area, sig: 11 [#1]

SMP NR_CPUS=128 NUMA PSERIES

Indeed there is a bug but a different one:
printk() parameters are interchanged.

#5 lore raw
Quoted 22 lines · Bartlomiej Zolnierkiewicz
Quoted 15 lines · Olaf Hering
Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 1 line · Bartlomiej Zolnierkiewicz

applied

and reversed, missing space is here: " CPU"

This was my oops:

Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2
ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx
W82C105: IDE controller at PCI slot 0000:00:03.1
W82C105: chipset revision 5
W82C105: 100% native mode on irq 102

Quoted 5 lines
    ide0: BM-DMA at 0xf040-0xf047<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
    ide1: BM-DMA at 0xf048-0xf04f<3> CPU: -- Error, unable to allocateW82C105 DMA table(s).
hda: HL-DT-ST CD-ROM GCR-8480B, ATAPI CD/DVD-ROM drive
Oops: Kernel access of bad area, sig: 11 [#1]

SMP NR_CPUS=128 NUMA PSERIES

Quoted 2 lines

Indeed there is a bug but a different one:
printk() parameters are interchanged.

Fix will be in the next ide-2.6 update (today).

Thanks.