Skip to contentSkip to conversation

eth1394: Change KERN_ERR to KERN_INFO

PATCH In review Steffen Zieger 3 participants 3 messages Feb 3, 2005 – Feb 5, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 eth1394: Change KERN_ERR to KERN_INFO

Hello list,

on boot eth1394 prints the following message to KERN_ERR, but I think it is better printing to KERN_INFO, because it _is_ an informational message only (or: I think so).
This is the message I mean:
eth1394: eth1: IEEE-1394 IPv4 over 1394 Ethernet (fw-host0)

The patch should apply against kernel 2.6.11-rc2 cleanly

HAND,
Steffen

Signature · 3 lines
Freiheit ist die Freiheit zu sagen, dass zwei und zwei gleich vier ist.
Sobald das gewährleistet ist, ergibt sich alles andere von selbst.
1984 - George Orwell
ieee1394/eth1394.c renamed from ieee1394/eth1394.c.orig +1 -1
@@ -626,7 +626,7 @@
 		goto out;
 	}
 
-	ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
+	ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
 		       host->id);
 
 	hi->host = host;
#1 lore raw
Quoted 9 lines · Steffen Zieger

Hello list,

on boot eth1394 prints the following message to KERN_ERR, but I think it is better printing to KERN_INFO, because it _is_ an informational message only (or: I think so).
This is the message I mean:
eth1394: eth1: IEEE-1394 IPv4 over 1394 Ethernet (fw-host0)

The patch should apply against kernel 2.6.11-rc2 cleanly

1. Please add Signed-off-by (see Documentation/SubmittingPatches ).

2. Please produce patches that apply -p1.

3. Please cc [email protected].

I made a new patch that applies to linux1394 SVN. Dan, if you agree with this change, please apply.

Thanks,
Jody

Quoted 11 lines

HAND,
Steffen

Signature · 3 lines
Freiheit ist die Freiheit zu sagen, dass zwei und zwei gleich vier ist.
Sobald das gew?hrleistet ist, ergibt sich alles andere von selbst.
1984 - George Orwell

ieee1394/eth1394.c line 632

Quoted 8 lines
ieee1394/eth1394.c renamed from ieee1394/eth1394.c.orig +1 -1
@@ -626,7 +626,7 @@
 		goto out;
 	}
 
-	ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
+	ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
 		       host->id);
 
 	hi->host = host;

Change the initialization message for eth1394 to KERN_INFO, requested by Steffen Zieger <[email protected]>

eth1394.c +1 -1
Index: ieee1394/eth1394.c
===================================================================
@@ -625,7 +625,7 @@ static void ether1394_add_host (struct h
 		goto out;
 	}
 
-	ETH1394_PRINT (KERN_ERR, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
+	ETH1394_PRINT (KERN_INFO, dev->name, "IEEE-1394 IPv4 over 1394 Ethernet (fw-host%d)\n",
 		       host->id);
 
 	hi->host = host;