Skip to contentSkip to conversation

Bug in tty_io.c after changes between 2.6.9-rc1-bk1 and 2.6.9-rc1-bk2

PATCH Olaf Hering 1 participant 2 messages Feb 6, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 22 lines · Linux Kernel Mailing List

ChangeSet 1.1992.2.73, 2005/02/02 08:48:23-08:00, [email protected]

[PATCH] Bug in tty_io.c after changes between 2.6.9-rc1-bk1 and 2.6.9-rc1-bk2

Fix http://bugzilla.kernel.org/show_bug.cgi?id=3736

Finally located that a problem seems to be a simple typo.

 tty_io.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -Nru a/drivers/char/tty_io.c b/drivers/char/tty_io.c

drivers/char/tty_io.c line 1161

Quoted 8 lines
drivers/char/tty_io.c +2 -2
@@ -1156,8 +1156,8 @@
 	int i = index + driver->name_base;
 	/* ->name is initialized to "ttyp", but "tty" is expected */
 	sprintf(p, "%s%c%x",
-			driver->subtype == PTY_TYPE_SLAVE ? "tty" : driver->name,
-			ptychar[i >> 4 & 0xf], i & 0xf);
+		driver->subtype == PTY_TYPE_SLAVE ? "pty" : driver->name,
+		ptychar[i >> 4 & 0xf], i & 0xf);
 }

This change looks very bogus, what are you trying to fix here?

if pty_driver->subtype == PTY_TYPE_MASTER, a node ptyXY has to be created. if pty_driver->subtype == PTY_TYPE_SLAVE, a node ttyXY has to be created. See Documentation/devices.txt, line 108ff and 183ff

With your change, the ttyXY becomes ptyXY? Why does that fix anything?

Do you have an outdated udev package with bogus udev.rules?

#2 lore raw
Quoted 1 line · Olaf Hering

Do you have an outdated udev package with bogus udev.rules?

Your strace clearly shows /dev/tty as a directory. Go and ask Linus to revert your broken patch.