drivers/isdn/tpam/: possible cleanups
PATCH 1/1 drivers/isdn/tpam/: possible cleanups
This patch makes the following possible cleanups:
- tpam_hdlc.c: make the needlessly global variable stuffs static
- tpam_nco.c: remove the unused global function build_ADestroyNCOReq
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/isdn/tpam/tpam.h | 1 - drivers/isdn/tpam/tpam_hdlc.c | 2 +- drivers/isdn/tpam/tpam_nco.c | 27 --------------------------- 3 files changed, 1 insertion(+), 29 deletions(-)
drivers/isdn/tpam/tpam_hdlc.c renamed from drivers/isdn/tpam/tpam_hdlc.c.old +1 -1
@@ -548,7 +548,7 @@static WORD * stuffs[] = { stuff0, stuff1, stuff2, stuff3, stuff4, stuff5 }; -WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 }; +static WORD * destuffs[] = { destuff0, destuff1, destuff2, destuff3, destuff4, destuff5 };/*- AuverTech Telecom -------------------------------------------------------+
drivers/isdn/tpam/tpam.h renamed from drivers/isdn/tpam/tpam.h.old +0 -1
@@ -181,7 +181,6 @@/* Function prototypes from tpam_nco.c */ extern struct sk_buff *build_ACreateNCOReq (const u8 *); -extern struct sk_buff *build_ADestroyNCOReq (u32 );extern struct sk_buff *build_CConnectReq (u32 ,const u8 *,u8 );extern struct sk_buff *build_CConnectRsp (u32 );extern struct sk_buff *build_CDisconnectReq (u32 );
drivers/isdn/tpam/tpam_nco.c renamed from drivers/isdn/tpam/tpam_nco.c.old +0 -27
@@ -131,33 +131,6 @@ }/* -* Build a ADestroyNCOReq message. -* -* ncoid: the NCO id. -* -* Return: the sk_buff filled with the NCO packet, or NULL if error. -*/ -struct sk_buff *build_ADestroyNCOReq (u32 ncoid) { -struct sk_buff *skb; -u8 *tlv; - -pr_debug ("TurboPAM(build_ADestroyNCOReq): ncoid=%lu\n" , - (unsigned long )ncoid); - -/* build the NCO packet */ -if (!(skb =build_NCOpacket (ID_ADestroyNCOReq,6 ,0 ,0 ,0 ))) -return NULL ; - -/* add the parameters */ - tlv = (u8 *)skb_put (skb,6 ); - *tlv =PAR_NCOID ; - *(tlv+1 ) =4 ; - *((u32 *)(tlv+2 )) = ncoid; - -return skb; -} - -/* * Build a CConnectReq message. * * ncoid: the NCO id.