Skip to contentSkip to conversation

Introduction

PATCH New NeilBrown 2 participants 5 messages Feb 9, 2005 – Feb 14, 2005

Subsystems (2)
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 Introduction

Two more little patches for md (sorry for the dribs-and-drabs).

Feel free to leave them until post-2.6.11, though the first is really trivial and allows md/multipath arrays be assembled (without it they just won't work).

- Fix typo for multipat assembly with will
- Mark raid6 non-experimental and tidy up bits of Kconfig

NeilBrown

author
#1 lore raw

PATCH 1/1 Fix multipath assembly bug

In md, there are "level" number and "personality" numbers. LEVEL_MULTIPATH is the level number for multipath. MULTIPATH is the personality number for multipath.

In one place, we compare the level with a personality ... bad

This makes it impossible to assemble multipath arrays.

### Diffstat output

 ./drivers/md/md.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/md/md.c renamed from drivers/md/md.c~current~ +1 -1
diff ./drivers/md/md.c~current~ ./drivers/md/md.c
@@ -572,7 +572,7 @@ static int super_90_load(mdk_rdev_t *rde
 	rdev->preferred_minor = sb->md_minor;
 	rdev->data_offset = 0;
 
-	if (sb->level == MULTIPATH)
+	if (sb->level == LEVEL_MULTIPATH)
 		rdev->desc_nr = -1;
 	else
 		rdev->desc_nr = sb->this_disk.number;
#2 lore raw

Re: [PATCH md 1 of 2] Fix multipath assembly bug

Quoted 3 lines · NeilBrown

In md, there are "level" number and "personality" numbers. LEVEL_MULTIPATH is the level number for multipath. MULTIPATH is the personality number for multipath.

BTW, why the two in the first place? Isn't it nice to eliminate one of them?

/mjt

author
#3 lore raw

Re: [PATCH md 1 of 2] Fix multipath assembly bug

Quoted 7 lines · On Thursday February 10, [email protected] wrote:
Quoted 3 lines · NeilBrown

In md, there are "level" number and "personality" numbers. LEVEL_MULTIPATH is the level number for multipath. MULTIPATH is the personality number for multipath.

BTW, why the two in the first place? Isn't it nice to eliminate one of them?

Historical reasons....

The "Level" number corresponds to the common names of the raid levels:
0, 1, 4, 5, 6 ...
There is also "-1" for "linear", which is a bit of a hack.

The personality numbers are dense small integers: 0 1 2 3 4 ... and are used for indexing.

You are right: the personality number isn't needed and could be eliminated, however it isn't a priority for me yet. Patches welcome
....

NeilBrown

author
#4 lore raw

PATCH 1/1 RAID Kconfig cleanups, remove experimental tag from RAID-6

In reply to NeilBrown

This patch removes the experimental tag from RAID-6 (unfortunately the damage is already done...:-|) and cleans up a few more things in the Kconfig file.

### Diffstat output

 ./drivers/md/Kconfig |   19 ++++++++-----------
 1 files changed, 8 insertions(+), 11 deletions(-)
drivers/md/Kconfig renamed from drivers/md/Kconfig~current~ +8 -11
diff ./drivers/md/Kconfig~current~ ./drivers/md/Kconfig
@@ -93,7 +93,7 @@ config MD_RAID10
 	  mirroring (RAID-1) with easier configuration and more flexable
 	  layout.
 	  Unlike RAID-0, but like RAID-1, RAID-10 requires all devices to
-	  be the same size (or atleast, only as much as the smallest device
+	  be the same size (or at least, only as much as the smallest device
 	  will be used).
 	  RAID-10 provides a variety of layouts that provide different levels
 	  of redundancy and performance.
@@ -102,6 +102,7 @@ config MD_RAID10
 
 	  ftp://ftp.kernel.org/pub/linux/utils/raid/mdadm/
 
+	  If unsure, say Y.
 
 config MD_RAID5
 	tristate "RAID-4/RAID-5 mode"
@@ -120,20 +121,16 @@ config MD_RAID5
 	  <http://www.tldp.org/docs.html#howto>. There you will also
 	  learn where to get the supporting user space utilities raidtools.
 
-	  If you want to use such a RAID-4/RAID-5 set, say Y.  To compile
-	  this code as a module, choose M here: the module will be called raid5.
+	  If you want to use such a RAID-4/RAID-5 set, say Y.  To
+	  compile this code as a module, choose M here: the module
+	  will be called raid5.
 
 	  If unsure, say Y.
 
 config MD_RAID6
-	tristate "RAID-6 mode (EXPERIMENTAL)"
-	depends on BLK_DEV_MD && EXPERIMENTAL
+	tristate "RAID-6 mode"
+	depends on BLK_DEV_MD
 	---help---
-	  WARNING: RAID-6 is currently highly experimental.  If you
-	  use it, there is no guarantee whatsoever that it won't
-	  destroy your data, eat your disk drives, insult your mother,
-	  or re-appoint George W. Bush.
-
 	  A RAID-6 set of N drives with a capacity of C MB per drive
 	  provides the capacity of C * (N - 2) MB, and protects
 	  against a failure of any two drives. For a given sector
@@ -150,7 +147,7 @@ config MD_RAID6
 	  this code as a module, choose M here: the module will be
 	  called raid6.
 
-	  If unsure, say N.
+	  If unsure, say Y.
 
 config MD_MULTIPATH
 	tristate "Multipath I/O support"