Skip to contentSkip to conversation

include/linux/* - compile warning cleanup

PATCH In review Stephen Biggs 2 participants 2 messages Feb 10, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 20/26 include/linux/* - compile warning cleanup

Description: compile warning cleanup - give RCS id string "unused" attribute to silence compiler warning

include/linux/ixjuser.h +1 -1
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm/include/linux/ixjuser.h
@@ -42,7 +42,7 @@
  *
  *****************************************************************************/
 
-static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
+static char  __attribute__((__unused__)) ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
 
 #include <linux/telephony.h>
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

On Thu, Feb 10, 2005 at 11:34:27PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body

Quoted 9 lines

Description: compile warning cleanup - give RCS id string "unused" attribute to silence compiler warning

diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/include/linux/ixjuser.h linux-2.6.11-rc3-mm/include/linux/ixjuser.h

include/linux/ixjuser.h line 45

Quoted 6 lines
include/linux/ixjuser.h +1 -1
@@ -42,7 +42,7 @@
  *
  *****************************************************************************/
 
-static char ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
+static char  __attribute__((__unused__)) ixjuser_h_rcsid[] = "$Id: ixjuser.h,v 4.1 2001/08/05 00:17:37 craigs Exp $";
...

This outdated string should better be killed (together with the only usage in ixj.c). If a driver and such a string is maintained it might make sense, but in this case it's simply useless.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors