Skip to contentSkip to conversation

kernel/power/* - fix compile ERROR that stops

PATCH In review Stephen Biggs 2 participants 3 messages Feb 10, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 22/26 kernel/power/* - fix compile ERROR that stops

Description: Error in Andrew Morton's 2.6.11-rc3-mm that causes my GCC to error out due to no static inline function body before call of that function

kernel/power/swsusp.c +14 -16
diff -Nurdp -X dontdiff-osdl linux-2.6.11-rc3-mm-original/kernel/power/swsusp.c linux-2.6.11-rc3-mm/kernel/power/swsusp.c
@@ -605,7 +605,20 @@ static int calc_nr(int nr_copy)
 	return nr_copy;
 }
 
-static inline void free_pagedir(struct pbe *pblist);
+/**
+ *	free_pagedir - free pages allocated with alloc_pagedir()
+ */
+
+static inline void free_pagedir(struct pbe *pblist)
+{
+	struct pbe *pbe;
+
+	while (pblist) {
+		pbe = pblist + PB_PAGE_SKIP;
+		pblist = pbe->next;
+		free_page((unsigned long)pblist);
+	}
+}
 
 /**
  *	alloc_pagedir - Allocate the page directory.
@@ -651,21 +664,6 @@ static struct pbe * alloc_pagedir(unsign
 }
 
 /**
- *	free_pagedir - free pages allocated with alloc_pagedir()
- */
-
-static inline void free_pagedir(struct pbe *pblist)
-{
-	struct pbe *pbe;
-
-	while (pblist) {
-		pbe = pblist + PB_PAGE_SKIP;
-		pblist = pbe->next;
-		free_page((unsigned long)pblist);
-	}
-}
-
-/**
  *	free_image_pages - Free pages allocated for snapshot
  */
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

On Thu, Feb 10, 2005 at 11:34:27PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body

Quoted 4 lines

Description: Error in Andrew Morton's 2.6.11-rc3-mm that causes my GCC to error out due to no static inline function body before call of that function
...

You should better say 2.6.11-rc3-mm1 since the fix is already in 2.6.11-rc3-mm2.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Stephen Biggs
Quoted 9 lines · Adrian Bunk

On Thu, Feb 10, 2005 at 11:34:27PM +0200, Stephen Biggs wrote:
Content-Description: Mail message body

Quoted 4 lines

Description: Error in Andrew Morton's 2.6.11-rc3-mm that causes my GCC to error out due to no static inline function body before call of that function
...

You should better say 2.6.11-rc3-mm1 since the fix is already in 2.6.11-rc3-mm2.

Yes, thank you. My mistake; I should have checked this better. My apologies.

Quoted 12 lines

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors