Skip to contentSkip to conversation

DISCUSSION Daniel Dickman 2 participants 2 messages Feb 13, 2005 – Feb 15, 2005

lore
Share & tools
lore
#0 lore raw

For the m32r architecture, is there a reason not to use the generic bug.h definition?

--- linux-2.6.11-rc4/include/asm-m32r/bug.h 2004-12-24 16:34:01.000000000
-0500
+++ linux/include/asm-m32r/bug.h 2005-02-13 03:39:39.775236000 -0500
@@ -1,22 +1,4 @@
#ifndef _M32R_BUG_H
#define _M32R_BUG_H
-
-#define BUG() do { \
- printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); \
-} while (0)
-
-#define PAGE_BUG(page) do { BUG(); } while (0)
-
-#define BUG_ON(condition) \
- do { if (unlikely((condition)!=0)) BUG(); } while(0)
-
-#define WARN_ON(condition) do { \
- if (unlikely((condition)!=0)) { \

-               printk("Badness in %s at %s:%d\n", __FUNCTION__, \
-               __FILE__, __LINE__); \
-               dump_stack(); \

- } \
-} while (0)
-
-#endif /* _M32R_BUG_H */
-
+#include <asm-generic/bug.h>
+#endif

#1 lore raw

asm-m32r/bug.h (was Re: )

Hi,

There is no special reason at this moment.
Please apply this patch.

Thank you.

From: Daniel Dickman <[email protected]>
Date: Sun, 13 Feb 2005 00:24:13 -0800 (PST)

Quoted 24 lines

For the m32r architecture, is there a reason not to use the generic bug.h definition?

--- linux-2.6.11-rc4/include/asm-m32r/bug.h 2004-12-24 16:34:01.000000000
-0500
+++ linux/include/asm-m32r/bug.h 2005-02-13 03:39:39.775236000 -0500

(quoted diff) +0 -12
@@ -1,22 +1,4 @@
 #ifndef _M32R_BUG_H
 #define _M32R_BUG_H
-
-#define BUG()  do { \
-       printk("kernel BUG at %s:%d!\n", __FILE__, __LINE__); \
-} while (0)
-
-#define PAGE_BUG(page) do { BUG(); } while (0)
-
-#define BUG_ON(condition) \
-       do { if (unlikely((condition)!=0)) BUG(); } while(0)
-
-#define WARN_ON(condition) do { \
-       if (unlikely((condition)!=0)) { \

Review line 4

Quoted 10 lines
(quoted diff) +2 -8
-               printk("Badness in %s at %s:%d\n", __FUNCTION__, \
-               __FILE__, __LINE__); \
-               dump_stack(); \
-       } \
-} while (0)
-
-#endif /* _M32R_BUG_H */
-
+#include <asm-generic/bug.h>
+#endif

--
Hirokazu Takata <[email protected]>
Linux/M32R Project: http://www.linux-m32r.org/