Skip to contentSkip to conversation

remove unneeded ext2 include from nfsd

PATCH In review Olaf Hering 2 participants 3 messages Feb 13, 2005 – Feb 14, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove unneeded ext2 include from nfsd

nfs3proc.c includes ext2 headers for some constants, strange. vfs.c does the same, but doesnt use anything from this header.

fs/nfsd/vfs.c renamed from linux-2.6.11-rc4.orig/fs/nfsd/vfs.c +0 -1
diff -purNx tags ../linux-2.6.11-rc4.orig/fs/nfsd/vfs.c ./fs/nfsd/vfs.c
@@ -24,7 +24,6 @@
 #include <linux/file.h>
 #include <linux/mount.h>
 #include <linux/major.h>
-#include <linux/ext2_fs.h>
 #include <linux/proc_fs.h>
 #include <linux/stat.h>
 #include <linux/fcntl.h>

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

#1 lore raw
Quoted 1 line · Olaf Hering

nfs3proc.c includes ext2 headers for some constants, strange.

It used to be that nfsd accessed the ext2 inode generation number directly, that's where the include came from, probably.

Olaf

Quoted 26 lines

vfs.c does the same, but doesnt use anything from this header.

diff -purNx tags ../linux-2.6.11-rc4.orig/fs/nfsd/vfs.c ./fs/nfsd/vfs.c

fs/nfsd/vfs.c renamed from linux-2.6.11-rc4.orig/fs/nfsd/vfs.c +0 -2
@@ -24,7 +24,6 @@
 #include <linux/file.h>
 #include <linux/mount.h>
 #include <linux/major.h>
-#include <linux/ext2_fs.h>
 #include <linux/proc_fs.h>
 #include <linux/stat.h>
 #include <linux/fcntl.h>
 
 
-------------------------------------------------------

SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs

Signature · 12 lines
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
[email protected] |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist  -  [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs
#2 lore raw
Quoted 5 lines · Olaf Kirch
Quoted 1 line · Olaf Hering

nfs3proc.c includes ext2 headers for some constants, strange.

It used to be that nfsd accessed the ext2 inode generation number directly, that's where the include came from, probably.

It looks for ext2/ext3 and msdos magic to tweak some settings.

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs