Skip to contentSkip to conversation

make ACPI_BLACKLIST_YEAR depend on ACPI

PATCH In review Rolf Eike Beer 4 participants 4 messages Feb 14, 2005 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make ACPI_BLACKLIST_YEAR depend on ACPI

Hi,

this oneliner fixes the situation that I can enter a year to blacklist ACPI devices if ACPI is completely disabled.

drivers/acpi/Kconfig.fixed renamed from drivers/acpi/Kconfig +1 -0
@@ -259,6 +259,7 @@
 
 config ACPI_BLACKLIST_YEAR
 	int "Disable ACPI for systems before Jan 1st this year"
+	depends on ACPI
 	default 0
 	help
 	  enter a 4-digit year, eg. 2001 to disable ACPI by default
#1 lore raw
Quoted 5 lines · Rolf Eike Beer

this oneliner fixes the situation that I can enter a year to blacklist ACPI devices if ACPI is completely disabled.

Hmm.. Wouldn't it be even better to make it depend on ACPI_INTERPRETER? Afaik, the blacklist year is only ever used by the interperter, and the blacklist.c file isn't even built unless ACPI_INTERPRETER is on.

Len Brown added to check..

Linus

Quoted 11 lines
drivers/acpi/Kconfig.fixed renamed from drivers/acpi/Kconfig +1 -0
@@ -259,6 +259,7 @@
 
 config ACPI_BLACKLIST_YEAR
 	int "Disable ACPI for systems before Jan 1st this year"
+	depends on ACPI
 	default 0
 	help
 	  enter a 4-digit year, eg. 2001 to disable ACPI by default
#2 lore raw

Re: ACPI_BLACKLIST_YEAR depending on ACPI or ACPI_INTERPRETER -- either are fine.

Note that I'm planning to delete the separate ACPI_INTERPRETER build option and just use CONFIG_ACPI in the future. We tested this in a config clean-up in -mm a while back, and I should probably revive it for early 2.6.12. The reason is that there really isn't a valid concept of ACPI without the interpreter -- it can't even be used for configuring interrupts without the interpreter on hand.

thanks,
-Len

#3 lore raw

Hi,

Quoted 2 lines · Len Brown

Re: ACPI_BLACKLIST_YEAR depending on ACPI or ACPI_INTERPRETER -- either are fine.

Note that a patch that fixes this and a little more is waiting in -mm and Sam's tree.

bye, Roman