Skip to contentSkip to conversation

drivers/net/irda/: possible cleanups

PATCH New Adrian Bunk 1 participant 1 message Feb 17, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/net/irda/: possible cleanups

This patch contains the following possible cleanups:
- make needlessly global code static
- remove unneeded EXPORT_SYMBOL's from irport.c
(the patch is a bit big since I moved some code to avoid some
forward declarations)

---

 drivers/net/irda/irport.c     |  127 ++++++++++++++++------------------
 drivers/net/irda/irport.h     |   10 --
 drivers/net/irda/irtty-sir.c  |    2 
 drivers/net/irda/smsc-ircc2.c |    2 
 4 files changed, 64 insertions(+), 77 deletions(-)
drivers/net/irda/irtty-sir.c renamed from drivers/net/irda/irtty-sir.c.old +1 -1
@@ -413,7 +413,7 @@
 
 /* ------------------------------------------------------- */
 
-struct sir_driver sir_tty_drv = {
+static struct sir_driver sir_tty_drv = {
 	.owner			= THIS_MODULE,
 	.driver_name		= "sir_tty",
 	.start_dev		= irtty_start_dev,
drivers/net/irda/smsc-ircc2.c renamed from drivers/net/irda/smsc-ircc2.c.old +1 -1
@@ -203,7 +203,7 @@
 
 /* Transceivers for SMSC-ircc */
 
-smsc_transceiver_t smsc_transceivers[]=
+static smsc_transceiver_t smsc_transceivers[]=
 {
 	{ "Toshiba Satellite 1800 (GP data pin select)", smsc_ircc_set_transceiver_toshiba_sat1800, smsc_ircc_probe_transceiver_toshiba_sat1800},
 	{ "Fast pin select", smsc_ircc_set_transceiver_smsc_ircc_fast_pin_select, smsc_ircc_probe_transceiver_smsc_ircc_fast_pin_select},
drivers/net/irda/irport.h renamed from drivers/net/irda/irport.h.old +0 -10
@@ -77,14 +77,4 @@
 	int (*interrupt)(int irq, void *dev_id, struct pt_regs *regs);
 };
 
-struct irport_cb *irport_open(int i, unsigned int iobase, unsigned int irq);
-int  irport_close(struct irport_cb *self);
-void irport_start(struct irport_cb *self);
-void irport_stop(struct irport_cb *self);
-void irport_change_speed(void *priv, __u32 speed);
-irqreturn_t irport_interrupt(int irq, void *dev_id, struct pt_regs *regs);
-int  irport_hard_xmit(struct sk_buff *skb, struct net_device *dev);
-int  irport_net_open(struct net_device *dev);
-int  irport_net_close(struct net_device *dev);
-
 #endif /* IRPORT_H */
drivers/net/irda/irport.c renamed from drivers/net/irda/irport.c.old +62 -65

200 lines not on this page · raw message