Skip to contentSkip to conversation

radeonfb: Clean up printk()'s in

PATCH Domen Puncer 1 participant 1 message Feb 21, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 13 lines · James Nelson
(quoted diff) +1 -1
@@ -28,6 +28,7 @@
  *
  */
 
+#undef DEBUG
 
 #define RADEON_VERSION	"0.1.6"
 
@@ -80,12 +81,8 @@
 #include <video/radeon.h>
 #include <linux/radeonfb.h>
 
-#define DEBUG	1

Review line 88

Quoted 10 lines
(quoted diff) +2 -5
-
-#if DEBUG
-#define RTRACE		printk
-#else
-#define RTRACE		if(0) printk
+#ifdef DEBUG
+#define RTRACE		pr_debug
 #endif
 
 // XXX

This produced warning, on !DEBUG RTRACE wasn't defined. Fixed for -kj, and also restored DEBUG behaviour which you turned off.

Domen

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors