Skip to contentSkip to conversation

Bind Mount Extensions 0.06

PATCH In review Herbert Poetzl 3 participants 5 messages Feb 22, 2005 – Feb 24, 2005

lore
Share & tools
lore
#0 lore raw

cover Bind Mount Extensions 0.06

Hi Andrew! Al! Folks!

The following set of patches extends the per device 'noatime', 'nodiratime' and last but not least the 'ro' (read only) mount option to the vfs --bind mounts, allowing them to behave like any other mount, by honoring those mount flags (which are silently ignored by the current implementation in 2.4.x and 2.6.x)

the patch makes the following syscall variations behave as expected:

- open (read/write/trunc), create
- link, symlink, unlink
- mknod (reg/block/char/fifo)
- mkfifo, mkdir, rmdir, rename
- (f,l)chown, (f)chmod, utime
- access, truncate, mmap
- ioctl (gen/ext2/ext3/reiser)
- (f,l)setxattr, (f,l)removexattr

an older version of this patch was included in 2.6.0-test6-mm2, and v2.6.4-wolk2.0, the patches were used by several people, without any issues ...

please consider inclusion (in -mm ?) and/or let me know what needs to be changed to get this functionality into mainline ...

patches are against 2.6.11-rc4 but they do apply fine against 2.6.11-rc4-bk9 (so no modification required)

TIA,
Herbert

(all six patches are)

#1 lore raw
Quoted 9 lines · Herbert Poetzl

Hi Andrew! Al! Folks!

The following set of patches extends the per device 'noatime', 'nodiratime' and last but not least the 'ro' (read only) mount option to the vfs --bind mounts, allowing them to behave like any other mount, by honoring those mount flags (which are silently ignored by the current implementation in 2.4.x and 2.6.x)

Please give each patch a unique, descriptive subject. Summarizing what each patch is doing in your 0/n so that reviewers can focus on the bits that are interesting is also helpful.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#2 lore raw
Quoted 2 lines · Matt Mackall

Please give each patch a unique, descriptive subject.

yup.

Quoted 3 lines

Summarizing what
each patch is doing in your 0/n so that reviewers can focus on the bits that are interesting is also helpful.

Actually, that's fairly irritating, because the 0/n contains useful info which someone has to go and massage and copy into 1/n.

#3 lore raw
Quoted 4 lines · Andrew Morton
Quoted 2 lines · Matt Mackall

Please give each patch a unique, descriptive subject.

Quoted 8 lines

yup.

Quoted 3 lines

Summarizing what
each patch is doing in your 0/n so that reviewers can focus on the bits that are interesting is also helpful.

Actually, that's fairly irritating, because the 0/n contains useful info which someone has to go and massage and copy into 1/n.

Certainly, there should be nothing in the summary that isn't already in the patch itself. What I'm suggesting is more a table of contents:

1/6 move foo to bar so that we can then remove baz 2/6 kill references to baz
...

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#4 lore raw
Quoted 14 lines · Matt Mackall
Quoted 4 lines · Andrew Morton
Quoted 2 lines · Matt Mackall

Please give each patch a unique, descriptive subject.

Quoted 8 lines

yup.

Quoted 3 lines

Summarizing what
each patch is doing in your 0/n so that reviewers can focus on the bits that are interesting is also helpful.

Actually, that's fairly irritating, because the 0/n contains useful info which someone has to go and massage and copy into 1/n.

Quoted 6 lines

Certainly, there should be nothing in the summary that isn't already in the patch itself. What I'm suggesting is more a table of contents:

1/6 move foo to bar so that we can then remove baz 2/6 kill references to baz
...

well, okay, that is in the comment at the start of the patch, (because it sometimes is rather lengthy) but I'll try to add something like a short version to the subject in the future ...

thanks for the input!
Herbert

Quoted 8 lines
Signature · 7 lines
-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/