aic7xxx: don't reset chip on pause]
PATCH 1/1 aic7xxx: don't reset chip on pause]
(resend)
Patch below taken from RHEL3 Update 4 kernel 2.4.21-27.EL, fixes a bug in the aic79xx and aic7xxx drivers, where upon trying to pause the controller chip, it is accidentally hard-reset. This causes PCI Parity errors to appear on Dell PowerEdge 4600 servers as the inb() immediately after accidental reset receives corrupted data.
Patch was submitted by Justin Gibbs many moons ago, but never applied to mainline 2.4. It's in mainlin 2.6. Marcelo, please apply.
Signature · 35 lines
Matt Domsch Software Architect Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com diff -urNp --exclude-from=/home/mdomsch/excludes --minimal ./aic79xx_pci.c /home/mdomsch/kernels/linux-2.4.21-27.EL/drivers/scsi/aic7xxx/aic79xx_pci.c --- ./aic79xx_pci.c Fri Feb 18 14:38:22 2005 +++ linux/drivers/scsi/aic7xxx/aic79xx_pci.c Wed Dec 1 20:49:28 2004 @@ -451,8 +457,10 @@ ahd_pci_test_register_access(struct ahd_ * or read prefetching could be initiated by the * CPU or host bridge. Our device does not support * either, so look for data corruption and/or flaged - * PCI errors. + * PCI errors. First pause without causing another + * chip reset. */ + hcntrl &= ~CHIPRST; ahd_outb(ahd, HCNTRL, hcntrl|PAUSE); while (ahd_is_paused(ahd) == 0) ; diff -urNp --exclude-from=/home/mdomsch/excludes --minimal ./aic7xxx_pci.c /home/mdomsch/kernels/linux-2.4.21-27.EL/drivers/scsi/aic7xxx/aic7xxx_pci.c --- ./aic7xxx_pci.c Fri Feb 18 14:38:22 2005 +++ /home/mdomsch/kernels/linux-2.4.21-27.EL/drivers/scsi/aic7xxx/aic7xxx_pci.c Wed Dec 1 20:49:28 2004 @@ -1284,8 +1284,10 @@ ahc_pci_test_register_access(struct ahc_ * or read prefetching could be initiated by the * CPU or host bridge. Our device does not support * either, so look for data corruption and/or flagged - * PCI errors. + * PCI errors. First pause without causing another + * chip reset. */ + hcntrl &= ~CHIPRST; ahc_outb(ahc, HCNTRL, hcntrl|PAUSE); while (ahc_is_paused(ahc) == 0) ;
Marcelo Tosatti
AppliedApplied, thanks.
Quoted 48 lines · Matt Domsch
(resend)
Patch below taken from RHEL3 Update 4 kernel 2.4.21-27.EL, fixes a bug in the aic79xx and aic7xxx drivers, where upon trying to pause the controller chip, it is accidentally hard-reset. This causes PCI Parity errors to appear on Dell PowerEdge 4600 servers as theinb()immediately after accidental reset receives corrupted data.Patch was submitted by Justin Gibbs many moons ago, but never applied to mainline 2.4. It's in mainlin 2.6. Marcelo, please apply.
Signed-off-by Matt Domsch <[email protected]>Signature · 6 lines
Matt Domsch Software Architect Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com diff -urNp --exclude-from=/home/mdomsch/excludes --minimal ./aic79xx_pci.c /home/mdomsch/kernels/linux-2.4.21-27.EL/drivers/scsi/aic7xxx/aic79xx_pci.cdrivers/scsi/aic7xxx/aic79xx_pci.c renamed from aic79xx_pci.c +3
-1@@ -451,8 +457,10 @@ ahd_pci_test_register_access(struct ahd_* or read prefetching could be initiated by the * CPU or host bridge. Our device does not support * either, so look for data corruption and/or flaged -* PCI errors. +* PCI errors. First pause without causing another +* chip reset. */ + hcntrl &= ~CHIPRST ;ahd_outb (ahd,HCNTRL , hcntrl|PAUSE );while (ahd_is_paused (ahd) ==0 ) ;diff -urNp --exclude-from=/home/mdomsch/excludes --minimal ./aic7xxx_pci.c
/home/mdomsch/kernels/linux-2.4.21-27.EL/drivers/scsi/aic7xxx/aic7xxx_pci.chome/mdomsch/kernels/linux-2.4.21-27.EL/drivers/scsi/aic7xxx/aic7xxx_pci.c renamed from aic7xxx_pci.c +3
-1@@ -1284,8 +1284,10 @@ ahc_pci_test_register_access(struct ahc_* or read prefetching could be initiated by the * CPU or host bridge. Our device does not support * either, so look for data corruption and/or flagged -* PCI errors. +* PCI errors. First pause without causing another +* chip reset. */ + hcntrl &= ~CHIPRST ;ahc_outb (ahc,HCNTRL , hcntrl|PAUSE );while (ahc_is_paused (ahc) ==0 ) ;