Skip to contentSkip to conversation

warn when iproute2 or bridge-utils are missing

PATCH In review Scott Parish 3 participants 4 messages Feb 25, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 warn when iproute2 or bridge-utils are missing

The attached patch checks for "ip" and "brctl" in the path, and warns the user if they are not found.

sRp

Signature · 1 line
Scott Parish
tools/misc/xend +18 -0
diff -rN -u xen-2.0.4-old/tools/misc/xend xen-2.0.4-new/tools/misc/xend
@@ -89,12 +89,30 @@
         msg("Xend must be run as root.")
         hline()
         raise CheckError("invalid user")
+
+def check_network_packages():
+    """Check that iproute2 and bridge-utils are installed.
+    """
+    def file_in_path(file):
+        return reduce(lambda a, b: a or b,
+                      [os.path.isfile(os.path.join(dir, file)) for
+                       dir in os.getenv("PATH").split(os.path.pathsep)], 0)
+    if not file_in_path("ip"):
+        hline()
+        msg("Warning: 'ip' not found in path: verify iproute2 is installed")
+        hline()
+    if not file_in_path("brctl"):
+        hline()
+        msg("Warning: 'brctl' not found in path: verify bridge-utils is installed")
+        hline()
+    
     
 def main():
     try:
         check_logging()
         check_twisted_version()
         check_user()
+        check_network_packages()
     except CheckError:
         sys.exit(1)
     daemon = SrvDaemon.instance()
#1 lore raw
Quoted 3 lines · Scott Parish

The attached patch checks for "ip" and "brctl" in the path, and warns the user if they are not found.

Now that the routed setup is included (and IMHO works a whole lot better) shouldn't the brctl check be optional somehow?

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#2 lore raw
Quoted 7 lines · Matt Ayres
Quoted 3 lines · Scott Parish

The attached patch checks for "ip" and "brctl" in the path, and warns the user if they are not found.

Now that the routed setup is included (and IMHO works a whole lot better) shouldn't the brctl check be optional somehow?

Maybe what i started to do would be better then: make sure that output from the scripts gets sent to the console in addition to getting buried in the log file. Then have the scripts check that the programs that they need are available (before fiddling with the network and putting it in a half way state).

sRp

Signature · 9 lines
Scott Parish



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
#3 lore raw

Isn't it more appropriate to have these be install-time checks?

It seems wasteful to check for an installed program every time a script is run. I submitted check scripts for iproute2 and iptables a while ago.

All you have to do is add a check_iproute2 script to the tools/check directory that basically looks like:

#!/bin/sh
which ip || (echo "Check for iproute2 failed && exit 1)

Regards,
Anthony Liguori

Quoted 17 lines · Scott Parish
Quoted 12 lines · Matt Ayres
Quoted 5 lines · Scott Parish

The attached patch checks for "ip" and "brctl" in the path, and warns the user if they are not found.

Now that the routed setup is included (and IMHO works a whole lot better) shouldn't the brctl check be optional somehow?

Quoted 10 lines

Maybe what i started to do would be better then: make sure that output from the scripts gets sent to the console in addition to getting buried in the log file. Then have the scripts check that the programs that they need are available (before fiddling with the network and putting it in a half way state).

sRp

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click