question ACPI & CMPXCHG
Sorry but... isn't already a dependency?
depends on (SMP || PREEMPT) && X86_CMPXCHG
Or a dependency where?
Besides, replacing a warning with an error directive... yaks, that hurts everybodies feelings isn't?
Vicente
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 11 lines · you
Quoted 6 lines · Vicente Feito
Sorry but... isn't already a dependency?
depends on (SMP || PREEMPT) && X86_CMPXCHGOr a dependency where?
...I see this only as a dependency for
HAVE_DEC_LOCK, not for ACPI.Where did you see this as an ACPI dependency?
Adrian,
No, you're right, it's only a HAVE_DEC_LOCK, I've grepped too fast... my bad
Walter, I agree with putting that in the Kconfig, but I still think an error it's more scary than a warning, most people don't care that much about wasting some compile time, but they do care (and freaks out) when an error appears in the compilation process...
Users won't complain for a warning if the overall works fine, but if you give them errors, well, they're not going to be happy... (users/admins/people that aren't crazy for optimization)
Vicente
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
hi list,
when i was looking into arch/i386/kernel/acpi/boot.c
i found:
#ifndef __HAVE_ARCH_CMPXCHG
#warning ACPI uses CMPXCHG, i486 and later hardware #endif
perhaps its nitpicking but ...
I think the setup should disable ACPI if CMPXCHG does not exist.
second best generate at least an error ! compile time these day is short and you have a good change to miss warnings.
re,
walter
(since i have no idea about the setup, no patch)
re,
walter
quick fix (better example) , hopyfully someone can find some better text
boot.c 2005-02-27 17:11:58.000000000 +0100 renamed from boot.c.org 2005-02-27 17:10:24.000000000 +0100 +1 -1
@@ -82,7 +82,7 @@ #endif #ifndef __HAVE_ARCH_CMPXCHG -#warning ACPI uses CMPXCHG, i486 and later hardware +#error ACPI requires CMPXCHG #endif #define MAX_MADT_ENTRIES 256
_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 18 lines · walter harms
hi list,
when i was looking intoarch/i386/kernel/acpi/boot.ci found:
#ifndef
__HAVE_ARCH_CMPXCHG
#warning ACPI uses CMPXCHG, i486 and later hardware #endifperhaps its nitpicking but ...
I think the setup should disable ACPI if CMPXCHG does not exist. second best generate at least an error ! compile time these day is short and you have a good change to miss warnings.
...
boot.c 2005-02-27 17:11:58.000000000 +0100 line 86
Quoted 7 lines
boot.c 2005-02-27 17:11:58.000000000 +0100 renamed from boot.c.org 2005-02-27 17:10:24.000000000 +0100 +1
-1@@ -82,7 +82,7 @@ #endif #ifndef __HAVE_ARCH_CMPXCHG -#warning ACPI uses CMPXCHG, i486 and later hardware +#error ACPI requires CMPXCHG #endif
This is wrong - instead of an error this should be put as a dependency into the Kconfig file.
But the underlying issue is that the current config semantics is, that "386" means a generic kernel. I should make a new version of my patch of a new i386 cpu selection for allowing a proper handling of such cases.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 6 lines · Vicente Feito
Sorry but... isn't already a dependency?
depends on (SMP || PREEMPT) && X86_CMPXCHGOr a dependency where?
...
I see this only as a dependency for HAVE_DEC_LOCK, not for ACPI.
Where did you see this as an ACPI dependency?
Quoted 1 line
Vicente
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors