Skip to contentSkip to conversation

aoe: fix printk warning (sparc64)

PATCH In review Randy.Dunlap 2 participants 2 messages Mar 2, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aoe: fix printk warning (sparc64)

aoeblk: mac_addr() returns u64, coerce to unsigned long long to printk it:
(sparc64 build warning)

drivers/block/aoe/aoeblk.c:245: warning: long long unsigned int format, u64 arg (arg 2) drivers/block/aoe/aoeblk.c:31: warning: long long unsigned int format, u64 arg (arg 4)

cross-compile results:
https://www.osdl.org/plm-cgi/plm?module=patch_info&patch_id=4239

diffstat:=

 drivers/block/aoe/aoeblk.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/block/aoe/aoeblk.c renamed from drivers/block/aoe/aoeblk.c~aoe_printk +4 -2
diff -Naurp ./drivers/block/aoe/aoeblk.c~aoe_printk ./drivers/block/aoe/aoeblk.c
@@ -28,7 +28,8 @@ static ssize_t aoedisk_show_mac(struct g
 {
 	struct aoedev *d = disk->private_data;
 
-	return snprintf(page, PAGE_SIZE, "%012llx\n", mac_addr(d->addr));
+	return snprintf(page, PAGE_SIZE, "%012llx\n",
+			(unsigned long long)mac_addr(d->addr));
 }
 static ssize_t aoedisk_show_netif(struct gendisk * disk, char *page)
 {
@@ -241,7 +242,8 @@ aoeblk_gdalloc(void *vp)
 	aoedisk_add_sysfs(d);
 	
 	printk(KERN_INFO "aoe: %012llx e%lu.%lu v%04x has %llu "
-		"sectors\n", mac_addr(d->addr), d->aoemajor, d->aoeminor,
+		"sectors\n", (unsigned long long)mac_addr(d->addr),
+		d->aoemajor, d->aoeminor,
 		d->fw_ver, (long long)d->ssize);
 }
 

---

#1 lore raw
Quoted 8 lines · Randy Dunlap

aoeblk: mac_addr() returns u64, coerce to unsigned long long to printk it:
(sparc64 build warning)

drivers/block/aoe/aoeblk.c:245: warning: long long unsigned int format, u64 arg (arg 2) drivers/block/aoe/aoeblk.c:31: warning: long long unsigned int format, u64 arg (arg 4)

cross-compile results:
https://www.osdl.org/plm-cgi/plm?module=patch_info&patch_id=4239

Thanks. I have a few patches I'll be sending along soon (today, I hope) in a batch, including Alexey Dobriyan's recent sparse cleanups, and I'll include this one among them.

Signature · 1 line
  Ed L Cashin <[email protected]>