Skip to contentSkip to conversation

fs/nfs4callback: replace schedule_timeout() with

PATCH In review Nishanth Aravamudan 2 participants 2 messages Jan 20, 2005 – Mar 1, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 7/40 fs/nfs4callback: replace schedule_timeout() with

Hi,

Please consider applying.

Description: Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected.

fs/nfsd/nfs4callback.c +2 -2
@@ -38,6 +38,7 @@
 #include <linux/list.h>
 #include <linux/inet.h>
 #include <linux/errno.h>
+#include <linux/delay.h>
 #include <linux/sunrpc/xdr.h>
 #include <linux/sunrpc/svc.h>
 #include <linux/sunrpc/clnt.h>
@@ -531,8 +532,7 @@ out:
 retry:
 	atomic_inc(&dp->dl_recall_cnt);
 	/* sleep 2 seconds before retrying recall */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(2*HZ);
+	ssleep(2);
 	status = nfsd4_cb_recall(dp);
 	dprintk("NFSD: nfs4_cb_recall_done: retry status: %d  dp %p dl_flock %p\n",status,dp, dp->dl_flock);
 }

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

[KJ] Re: [NFS] [PATCH 7/40] fs/nfs4callback: replace

Quoted 4 lines · Nishanth Aravamudan

Please consider applying.

Description: Use ssleep() instead of schedule_timeout() to guarantee the task delays as expected.

Thanks, but a different fix for this has been submitted. (Our sleeping at all there is a bug.)--b.

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors