Skip to contentSkip to conversation

remove drivers/usb/image/hpusbscsi.c

PATCH Applied Adrian Bunk 4 participants 5 messages Mar 3, 2005 – Mar 18, 2005 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove drivers/usb/image/hpusbscsi.c

USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the preferred way to access these devices.

Unless someone plans to resurrect this driver, I'm therefore proposing this patch to completely remove it.

---

 drivers/usb/Makefile          |    1 
 drivers/usb/image/Kconfig     |   11 
 drivers/usb/image/Makefile    |    1 
 drivers/usb/image/hpusbscsi.c |  523 ----------------------------------
 drivers/usb/image/hpusbscsi.h |   73 ----
 5 files changed, 609 deletions(-)
drivers/usb/image/Kconfig renamed from drivers/usb/image/Kconfig.old +0 -11
@@ -28,14 +28,3 @@
 	  The scanner will appear as a scsi generic device to the rest
 	  of the system. Scsi support is required.
 	  This driver can be compiled as a module, called microtek.
-
-config USB_HPUSBSCSI
-	tristate "HP53xx USB scanner support"
-	depends on USB && SCSI && BROKEN
-	help
-	  Say Y here if you want support for the HP 53xx series of scanners
-	  and the Minolta Scan Dual.
-	  The scanner will be accessible as a SCSI device.
-	  Please note that recent versions of SANE use usbfs, not this driver.
-	  This can be compiled as a module, called hpusbscsi.
-
drivers/usb/Makefile renamed from drivers/usb/Makefile.old +0 -1
@@ -51,7 +51,6 @@
 obj-$(CONFIG_USB_RTL8150)	+= net/
 obj-$(CONFIG_USB_USBNET)	+= net/
 
-obj-$(CONFIG_USB_HPUSBSCSI)	+= image/
 obj-$(CONFIG_USB_MDC800)	+= image/
 obj-$(CONFIG_USB_MICROTEK)	+= image/
 
drivers/usb/image/Makefile renamed from drivers/usb/image/Makefile.old +0 -1
@@ -3,5 +3,4 @@
 #
 
 obj-$(CONFIG_USB_MDC800)	+= mdc800.o
-obj-$(CONFIG_USB_HPUSBSCSI)	+= hpusbscsi.o
 obj-$(CONFIG_USB_MICROTEK)	+= microtek.o
drivers/usb/image/hpusbscsi.h deleted +0 -73

73 lines not on this page · raw message

drivers/usb/image/hpusbscsi.c deleted +0 -523

523 lines not on this page · raw message

#1 lore raw

Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:

Quoted 2 lines

USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the preferred way to access these devices.

That is true only if you limit yourself to users of SANE. Other, rarer scan systems like VueScan use it. At least last time somebody mentioned them. Do you have any hard evidence that it is unused? 2.6.11 is out less than three days, which is not enough for people to complain.

Regards
Oliver

#2 lore raw

* Oliver Neukum <[email protected]>:

Quoted 7 lines

Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:

Quoted 2 lines

USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the preferred way to access these devices.

That is true only if you limit yourself to users of SANE. Other, rarer scan systems like VueScan use it. At least last time somebody mentioned them.

Vuescan uses libusb these days, didn't need hpusbscsi last time I used it.
I don't know about other (program-) users.

Signature · 1 line
   Psi -- <http://www.iki.fi/pasi.savolainen>
#3 lore raw

Am Donnerstag, 3. März 2005 20:48 schrieb Pasi Savolainen:

Quoted 5 lines

* Oliver Neukum <[email protected]>:

Quoted 4 lines

Am Donnerstag, 3. März 2005 14:38 schrieb Adrian Bunk:

Quoted 2 lines

USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the preferred way to access these devices.

Quoted 7 lines
Quoted 3 lines

That is true only if you limit yourself to users of SANE. Other, rarer scan systems like VueScan use it. At least last time somebody mentioned them.

Vuescan uses libusb these days, didn't need hpusbscsi last time I used it.
I don't know about other (program-) users.

OK. That should solve the issue. It can go.

Regards
Oliver

Applied
#4 lore raw
In reply to Adrian Bunk
Quoted 7 lines · Adrian Bunk

USB_HPUSBSCSI was marked as BROKEN in 2.6.11 since libsane is the preferred way to access these devices.

Unless someone plans to resurrect this driver, I'm therefore proposing this patch to completely remove it.

Applied, thanks.

greg k-h