Skip to contentSkip to conversation

ppc/pmac_cpufreq: use poll_event*() interface

RFC PATCH In review Nishanth Aravamudan 1 participant 1 message Mar 3, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 3/5 ppc/pmac_cpufreq: use poll_event*() interface

Hi,

Description: Use new poll_event() interface to encapsulate sleep-loops.

arch/ppc/platforms/pmac_cpufreq.c +2 -7
@@ -167,8 +167,6 @@ static unsigned int __pmac dfs_get_cpu_s
  */
 static int __pmac gpios_set_cpu_speed(int low_speed)
 {
-	int gpio;
-
 	/* If ramping up, set voltage first */
 	if (low_speed == 0) {
 		pmac_call_feature(PMAC_FTR_WRITE_GPIO, NULL, voltage_gpio, 0x05);
@@ -180,11 +178,8 @@ static int __pmac gpios_set_cpu_speed(in
 	pmac_call_feature(PMAC_FTR_WRITE_GPIO, NULL, frequency_gpio,
 			  low_speed ? 0x04 : 0x05);
 	udelay(200);
-	do {
-		set_current_state(TASK_UNINTERRUPTIBLE);
-		schedule_timeout(1);
-		gpio = pmac_call_feature(PMAC_FTR_READ_GPIO, NULL, slew_done_gpio, 0);
-	} while((gpio & 0x02) == 0);
+	/* check every millisecond until true */
+	poll_event(((pmac_call_feature(PMAC_FTR_READ_GPIO, NULL, slew_done_gpio, 0) & 0x02) != 0), 1);
 
 	/* If ramping down, set voltage last */
 	if (low_speed == 1) {

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors