Skip to contentSkip to conversation

Fix scripts/mkuboot.sh to return status

PATCH In review George G. Davis 2 participants 2 messages Mar 3, 2005 – Mar 13, 2005 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix scripts/mkuboot.sh to return status

Sam,

If mkimage is either not found in search path or returns non-zero status, make uImage succeeds when it should fail. This changes scripts/mkuboot.sh to return status so build succeeds or fails as appropriate.

Source: MontaVista Software, Inc.
MR: 10761
Type: Defect Fix
Disposition: submitted to [email protected] Keywords:
Description:
Fix scripts/mkuboot.sh to return non-zero status to indicate build failure when uImage target is not created.

scripts/mkuboot.sh +3 -1
Index: linux-2.6.11-bk/scripts/mkuboot.sh
===================================================================
@@ -9,8 +9,10 @@
 if [ -z "${MKIMAGE}" ]; then
 	# Doesn't exist
 	echo '"mkimage" command not found - U-Boot images will not be built' >&2
-	exit 0;
+	exit -1
 fi
 
 # Call "mkimage" to create U-Boot image
 ${MKIMAGE} "$@"
+
+exit $?

--
Regards,
George

#1 lore raw
Quoted 5 lines · George G. Davis

Sam,

If mkimage is either not found in search path or returns non-zero status, make uImage succeeds when it should fail. This changes scripts/mkuboot.sh to return status so build succeeds or fails as appropriate.

As per mail from Tom Roni I dropped this patch.

Sam