Skip to contentSkip to conversation

Fix adm1021 alarms mask

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 Fix adm1021 alarms mask

Hi Greg,

This patch fixes an incorrect bitmasking on the status register in the adm1021 driver, which was causing high alarm on remote temperature to be hidden.
This bug was found and reported by Jayakrishnan:
http://bugzilla.kernel.org/show_bug.cgi?idB85

Please apply,
thanks.

Signed-off-by Jean Delvare
drivers/i2c/chips/adm1021.c renamed from drivers/i2c/chips/adm1021.c.orig +1 -1
@@ -380,7 +380,7 @@
 		data->remote_temp_input = adm1021_read_value(client, ADM1021_REG_REMOTE_TEMP);
 		data->remote_temp_max = adm1021_read_value(client, ADM1021_REG_REMOTE_TOS_R);
 		data->remote_temp_hyst = adm1021_read_value(client, ADM1021_REG_REMOTE_THYST_R);
-		data->alarms = adm1021_read_value(client, ADM1021_REG_STATUS) & 0xec;
+		data->alarms = adm1021_read_value(client, ADM1021_REG_STATUS) & 0x7c;
 		if (data->type = adm1021)
 			data->die_code = adm1021_read_value(client, ADM1021_REG_DIE_CODE);
 		if (data->type = adm1023) {
Signature · 1 line
Jean Delvare
Applied
#1 lore raw

PATCH 1/1 Fix adm1021 alarms mask

Quoted 7 lines · Jean Delvare

Hi Greg,

This patch fixes an incorrect bitmasking on the status register in the adm1021 driver, which was causing high alarm on remote temperature to be hidden.
This bug was found and reported by Jayakrishnan:
http://bugzilla.kernel.org/show_bug.cgi?idB85

Applied, thanks.

greg k-h