Skip to contentSkip to conversation

net/skethtool: remove duplicate delay

PATCH Applied [email protected] 1 participant 1 message Mar 6, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 15/26 net/skethtool: remove duplicate delay

Please consider applying.

Remove an unnecessary second (and identical) delay. schedule_timeout() does not need to be called, as msleep_interruptible() already delayed the task.

---

 kj-domen/drivers/net/sk98lin/skethtool.c |    3 ---
 1 files changed, 3 deletions(-)
drivers/net/sk98lin/skethtool.c renamed from drivers/net/sk98lin/skethtool.c~remove_duplicate_delay-drivers_net_sk98lin_skethtool +0 -3
diff -puN drivers/net/sk98lin/skethtool.c~remove_duplicate_delay-drivers_net_sk98lin_skethtool drivers/net/sk98lin/skethtool.c
@@ -437,9 +437,6 @@ static int locateDevice(struct net_devic
 	pAC->LedsOn = 0;
 	mod_timer(&pAC->BlinkTimer, jiffies);
 	msleep_interruptible(data * 1000);
-
-	set_current_state(TASK_INTERRUPTIBLE);
-	schedule_timeout(data * HZ);
 	del_timer_sync(&pAC->BlinkTimer);
 	toggleLeds(pNet, 0);
 

_