Skip to contentSkip to conversation

net/orinoco_plx: replace schedule_timeout() with ssleep()

PATCH In review [email protected] 2 participants 2 messages Mar 6, 2005 – Mar 7, 2005

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/2 net/orinoco_plx: replace schedule_timeout() with ssleep()

Use ssleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>

---

 kj-domen/drivers/net/wireless/orinoco_plx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/orinoco_plx.c renamed from drivers/net/wireless/orinoco_plx.c~ssleep-drivers_net_wireless_orinoco_plx +2 -2
diff -puN drivers/net/wireless/orinoco_plx.c~ssleep-drivers_net_wireless_orinoco_plx drivers/net/wireless/orinoco_plx.c
@@ -136,6 +136,7 @@
 #include <linux/list.h>
 #include <linux/pci.h>
 #include <linux/fcntl.h>
+#include <linux/delay.h>
 
 #include <pcmcia/cisreg.h>
 

@@ -352,8 +353,7 @@ static int __init orinoco_plx_init(void)
 static void __exit orinoco_plx_exit(void)
 {
 	pci_unregister_driver(&orinoco_plx_driver);
-	current->state = TASK_UNINTERRUPTIBLE;
-	schedule_timeout(HZ);
+	ssleep(1);
 }
 
 module_init(orinoco_plx_init);

_

#1 lore raw
Quoted 7 lines · On Sun, Mar 06, 2005 at 11:21:40PM +0100, [email protected] wrote:

Use ssleep() instead of schedule_timeout()
to guarantee the task delays as expected.

Signed-off-by Nishanth Aravamudan <[email protected]>
Signed-off-by Maximilian Attems <[email protected]>
Signed-off-by Domen Puncer <[email protected]>

Already in CVS, patch already sent to Jeff. Likewise for orinoco_tmd.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist.  NOT _the_ _other_ _way_
				| _around_!
http://www.ozlabs.org/people/dgibson