Skip to contentSkip to conversation

net/islpci_dev: replace schedule_timeout() with msleep()

PATCH In review [email protected] 2 participants 2 messages Mar 6, 2005 – Mar 7, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 net/islpci_dev: replace schedule_timeout() with msleep()

Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected. Also set_current_state() is inserted before schedule_timeout().

---

 kj-domen/drivers/net/wireless/prism54/islpci_dev.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/net/wireless/prism54/islpci_dev.c renamed from drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev +1 -2
diff -puN drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev drivers/net/wireless/prism54/islpci_dev.c
@@ -438,8 +438,7 @@ prism54_bring_down(islpci_private *priv)
 	wmb();
 
 	/* wait a while for the device to reset */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(50*HZ/1000);
+	msleep(50);
 
 	return 0;
 }

_

#1 lore raw

Patch applied to prism54 latest svn tree, thanks

Luis

Quoted 31 lines · On Sun, Mar 06, 2005 at 11:23:51PM +0100, [email protected] wrote:

Use msleep() instead of schedule_timeout()
to guarantee the task delays as expected. Also set_current_state() is inserted before schedule_timeout().

---

 kj-domen/drivers/net/wireless/prism54/islpci_dev.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev drivers/net/wireless/prism54/islpci_dev.c

drivers/net/wireless/prism54/islpci_dev.c renamed from drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev +1 -2
@@ -438,8 +438,7 @@ prism54_bring_down(islpci_private *priv)
 	wmb();
 
 	/* wait a while for the device to reset */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(50*HZ/1000);
+	msleep(50);
 
 	return 0;
 }

_

Signature · 1 line
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E