Skip to contentSkip to conversation

message/mptbase: replace schedule_timeout() with ssleep()

PATCH In review [email protected] 1 participant 1 message Mar 6, 2005 LSI Logic MPT fusion drivers (FC/SAS/SPI)

lore
Share & tools
lore
#0 lore raw

PATCH 11/14 message/mptbase: replace schedule_timeout() with ssleep()

Use ssleep() instead of schedule_timeout() to guarantee
the task delays as expected. The original code does use TASK_INTERRUPTIBLE, but does not check for signals or early return from schedule_timeout() so ssleep() seems more appropriate.

---

 kj-domen/drivers/message/fusion/mptbase.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)
drivers/message/fusion/mptbase.c renamed from drivers/message/fusion/mptbase.c~ssleep-drivers_message_fusion_mptbase +1 -2
diff -puN drivers/message/fusion/mptbase.c~ssleep-drivers_message_fusion_mptbase drivers/message/fusion/mptbase.c
@@ -3137,8 +3137,7 @@ mpt_diag_reset(MPT_ADAPTER *ioc, int ign
 
 				/* wait 1 sec */
 				if (sleepFlag == CAN_SLEEP) {
-					set_current_state(TASK_INTERRUPTIBLE);
-					schedule_timeout(1000 * HZ / 1000);
+					ssleep(1);
 				} else {
 					mdelay (1000);
 				}

_