Skip to contentSkip to conversation

Kill unused struct members in w83627hf driver

PATCH New Jean Delvare 2 participants 2 messages May 19, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Kill unused struct members in w83627hf driver

Hi Greg,

I just noticed that the pwmenable struct members in the w83627hf driver are not used anywhere (and quite rightly so, as PWM cannot be disabled in these chips as far as I know). Let's just get rid of them and save some bytes of memory.

Please apply,
thanks.

drivers/i2c/chips/w83627hf.c renamed from drivers/i2c/chips/w83627hf.c.orig +0 -5
@@ -304,7 +304,6 @@
 	u32 beep_mask;		/* Register encoding, combined */
 	u8 beep_enable;		/* Boolean */
 	u8 pwm[3];		/* Register value */
-	u8 pwmenable[3];	/* bool */
 	u16 sens[3];		/* 782D/783S only.
 				   1 = pentium diode; 2 = 3904 diode;
 				   3000-5000 = thermistor beta.
@@ -1316,10 +1315,6 @@
 		if ((type = w83697hf) && (i = 2))
 			break;
 	}
-
-	data->pwmenable[0] = 1;
-	data->pwmenable[1] = 1;
-	data->pwmenable[2] = 1;
 
 	if(init) {
 		/* Enable temp2 */
Signature · 1 line
Jean Delvare
Applied
#1 lore raw

PATCH 1/1 Kill unused struct members in w83627hf driver

Quoted 6 lines · Jean Delvare

Hi Greg,

I just noticed that the pwmenable struct members in the w83627hf driver are not used anywhere (and quite rightly so, as PWM cannot be disabled in these chips as far as I know). Let's just get rid of them and save some bytes of memory.

Applied, thanks.

greg k-h