Skip to contentSkip to conversation

Fix warning in gkc (make gconfig) {Scanned}

PATCH In review Romain Lievin 3 participants 3 messages Mar 9, 2005 – Mar 13, 2005 Kconfig

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix warning in gkc (make gconfig) {Scanned}

Hi,

this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc (the GTK Kernel Configurator).

Please apply.

Thanks, Romain.

================[cut here]====================

scripts/kconfig/gconf.c +3 -3
diff -Naur linux-2.6.11-rc3/scripts/kconfig/gconf.c linux/scripts/kconfig/gconf.c
@@ -222,15 +222,15 @@
 	switch (view_mode) {
 	case SINGLE_VIEW:
 		widget = glade_xml_get_widget(xml, "button4");
-		gtk_button_clicked(GTK_BUTTON(widget));
+		g_signal_emit_by_name(widget, "clicked");
 		break;
 	case SPLIT_VIEW:
 		widget = glade_xml_get_widget(xml, "button5");
-		gtk_button_clicked(GTK_BUTTON(widget));
+		g_signal_emit_by_name(widget, "clicked");
 		break;
 	case FULL_VIEW:
 		widget = glade_xml_get_widget(xml, "button6");
-		gtk_button_clicked(GTK_BUTTON(widget));
+		g_signal_emit_by_name(widget, "clicked");
 		break;
 	}
 

================[cut here]====================

Signature · 3 lines
Romain Liévin :		<[email protected]>
Web site :		http://www.lievin.net
"Linux, y'a moins bien mais c'est plus cher !"
#1 lore raw
Quoted 4 lines · Romain Lievin

Hi,

this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc (the GTK Kernel Configurator).

Applied, 2 warnings fixed - 10 more to go.
Care to take a look at them?
Also gconfig does not support setting localversion - is this something you can fix too?

Sam

#2 lore raw
Quoted 4 lines · Sam Ravnborg
Quoted 2 lines · Romain Lievin

Hi,

Quoted 8 lines
Quoted 2 lines

this patch against 2.6.11-rc3 fixes some warnings about GtkToolButton in gkc (the GTK Kernel Configurator).

Applied, 2 warnings fixed - 10 more to go.
Care to take a look at them?
Also gconfig does not support setting localversion - is this something you can fix too?

fyi, gconfig doesn't display those cute little pixmap buttons any more. That bug was introduced by the patch "make gconfig work with gtk-2.4".

I'm planning on simply reverting that patch. Which should motivate someone to have another go at fixing it for gtk2.4.