netpoll fix racy dev->flags usage
Subsystems (2)
PATCH 1/1 netpoll fix racy dev->flags usage
Put ndev->flags usage under the lock. Spotted by Patrick McHardy.
Signed-off-by Matt Mackall <[email protected]>
net/core/netpoll.c +1 -4
@@ -632,16 +632,13 @@ int netpoll_setup(struct netpoll *np) }if (!netif_running (ndev)) { -unsigned short oflags;unsigned long atmost, atleast;printk (KERN_INFO "%s: device %s not up yet, forcing it\n" , np->name, np->dev_name); - oflags = ndev->flags; -rtnl_shlock (); -if (dev_change_flags (ndev, oflags |IFF_UP ) <0 ) { +if (dev_change_flags (ndev, ndev->flags |IFF_UP ) <0 ) {printk (KERN_ERR "%s: failed to open %s\n" , np->name, np->dev_name);rtnl_shunlock ();
Signature · 1 line
Mathematics is the supreme nostalgia of our time.
Quoted 3 lines · On Thu, 10 Mar 2005 15:22:46 -0800 Matt Mackall <[email protected]> wrote:
Put
ndev->flagsusage under the lock. Spotted by Patrick McHardy.Signed-off-by Matt Mackall <[email protected]>
Applied, thanks Matt.