be more verbose in gen-devlist
PATCH 1/1 be more verbose in gen-devlist
gen-devlist should print how many bytes will be cut off and pci.ids entry. Also print the removed '[more blah]' part.
drivers/pci/gen-devlist.c renamed from linux-2.6.10/drivers/pci/gen-devlist.c +11 -1
@@ -72,9 +72,19 @@ main(void)/* Too long, try cutting off long description */ bra =strchr (c,'[' ); if (bra && bra > c && bra[-1] == ' ') +#if 0 + { +fprintf (stderr,"Line %d: cut off '%s' from line:\n" , lino, bra); +fprintf (stderr," '%s'\n" , c); bra[-1 ] =0 ; +fprintf (stderr," '%s'\n" , c); + } +#else + bra[-1 ] =0 ; +#endif if (vendor_len +strlen (c) +1 >MAX_NAME_SIZE ) { -fprintf (stderr,"Line %d: Device name too long. Name truncated.\n" , lino); +fprintf (stderr,"Line %d: Device name %d chars too long. Name truncated.\n" , + lino, (vendor_len +strlen (c) +1 ) -MAX_NAME_SIZE );fprintf (stderr,"%s\n" , c);/*return 1;*/ }
Quoted 12 lines · Olaf Hering
gen-devlist should print how many bytes will be cut off and pci.ids entry. Also print the removed '[more blah]' part.
Signed-off-by Olaf Hering <[email protected]>drivers/pci/gen-devlist.c renamed from linux-2.6.10/drivers/pci/gen-devlist.c +0
-0@@ -72,9 +72,19 @@ main(void)/* Too long, try cutting off long description */ bra =strchr (c,'[' );if (bra && bra > c && bra[-1 ] ==' ' )
drivers/pci/gen-devlist.c main(void) · line 84
Quoted 10 lines
drivers/pci/gen-devlist.c renamed from linux-2.6.10/drivers/pci/gen-devlist.c +9
-0+#if 0 + { +fprintf (stderr,"Line %d: cut off '%s' from line:\n" , lino, bra); +fprintf (stderr," '%s'\n" , c); bra[-1 ] =0 ; +fprintf (stderr," '%s'\n" , c); + } +#else + bra[-1 ] =0 ; +#endif
Why #if this? Why not just always do this?
thanks,
greg k-h
Quoted 1 line · Greg KH
Why #if this? Why not just always do this?
Because it always triggers with current sf.net snapshot.
Quoted 5 lines · Olaf Hering
Quoted 1 line · Greg KH
Why #if this? Why not just always do this?
Because it always triggers with current sf.net snapshot.
Someone said they were going to submit those shorter strings that the kernel has, back to sf.net. Guess that didn't happen yet, and is the main reason I can't just sync up all the time with that repository.
Oh well, we'll be dropping support for the pci.ids file by the end of the year or so, so it's not that big of a deal.
thanks,
greg k-h
Quoted 10 lines · Greg KH
Quoted 5 lines · Olaf Hering
Quoted 1 line · Greg KH
Why #if this? Why not just always do this?
Because it always triggers with current sf.net snapshot.
Someone said they were going to submit those shorter strings that the kernel has, back to sf.net. Guess that didn't happen yet, and is the main reason I can't just sync up all the time with that repository.
I did update the database a few days ago.