Skip to contentSkip to conversation

atyfb: Add boot/module option to override composite sync

PATCH In review Antonino A. Daplas 3 participants 3 messages Mar 13, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/6 atyfb: Add boot/module option to override composite sync

Some SPARC-based displays need the composite sync set to high. Since none of the entries in the default db has the composite sync set to high, using fb_find_mode() will produce a blank display.

Add this new option to Documentation/fb/aty128fb.txt

---

Documentation/fb/aty128fb.txt | 1 +

 drivers/video/aty/atyfb_base.c |   13 +++++++++++++
 2 files changed, 14 insertions(+)
Documentation/fb/aty128fb.txt +1 -0
diff -Nru a/Documentation/fb/aty128fb.txt b/Documentation/fb/aty128fb.txt
@@ -54,6 +54,7 @@
 
 noaccel  - do not use acceleration engine. It is default.
 accel    - use acceleration engine. Not finished.
+comp_sync- set composite sync, 0 for low, 1 for high.
 vmode:x  - chooses PowerMacintosh video mode <x>. Depreciated.
 cmode:x  - chooses PowerMacintosh colour mode <x>. Depreciated.
 <XxX@X>  - selects startup videomode. See modedb.txt for detailed
drivers/video/aty/atyfb_base.c +13 -0
diff -Nru a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
@@ -307,6 +307,7 @@
 static int pll;
 static int mclk;
 static int xclk;
+static int comp_sync __initdata = -1;
 static char *mode;
 
 #ifdef CONFIG_PPC
@@ -2527,6 +2528,13 @@
 	else
 		var.accel_flags |= FB_ACCELF_TEXT;
 
+	if (comp_sync != -1) {
+		if (!comp_sync)
+			var.sync &= ~FB_SYNC_COMP_HIGH_ACT;
+		else
+			var.sync |= FB_SYNC_COMP_HIGH_ACT;
+	}
+
 	if (var.yres == var.yres_virtual) {
 		u32 videoram = (info->fix.smem_len - (PAGE_SIZE << 2));
 		var.yres_virtual = ((videoram * 8) / var.bits_per_pixel) / var.xres_virtual;
@@ -3612,6 +3620,8 @@
 			mclk = simple_strtoul(this_opt + 5, NULL, 0);
 		else if (!strncmp(this_opt, "xclk:", 5))
 			xclk = simple_strtoul(this_opt+5, NULL, 0);
+		else if (!strncmp(this_opt, "comp_sync:", 10))
+			comp_sync = simple_strtoul(this_opt+10, NULL, 0);
 #ifdef CONFIG_PPC
 		else if (!strncmp(this_opt, "vmode:", 6)) {
 			unsigned int vmode =
@@ -3701,6 +3711,9 @@
 MODULE_PARM_DESC(mclk, "int: override memory clock");
 module_param(xclk, int, 0);
 MODULE_PARM_DESC(xclk, "int: override accelerated engine clock");
+module_param(comp_sync, int, 0);
+MODULE_PARM_DESC(comp_sync,
+		 "Set composite sync signal to low (0) or high (1)");
 module_param(mode, charp, 0);
 MODULE_PARM_DESC(mode, "Specify resolution as \"<xres>x<yres>[-<bpp>][@<refresh>]\" ");
 #ifdef CONFIG_MTRR

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

#1 lore raw
Quoted 6 lines · Antonino A. Daplas

Some SPARC-based displays need the composite sync set to high. Since none of the entries in the default db has the composite sync set to high, using fb_find_mode() will produce a blank display.

Add this new option to Documentation/fb/aty128fb.txt

Wrong documentation file!

Quoted 4 lines

---

Documentation/fb/aty128fb.txt | 1 +

aty128fb.txt is for ATI RAGE128 ...

Quoted 1 line
 drivers/video/aty/atyfb_base.c |   13 +++++++++++++

... while atyfb_base.c is for ATI Mach64.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

Acked-by on v1 1/6
#2 lore raw
In reply to Antonino A. Daplas

Am Sonntag, 13. März 2005 01:32 schrieb Antonino A. Daplas:

Quoted 8 lines

Some SPARC-based displays need the composite sync set to high. Since none of the entries in the default db has the composite sync set to high, using fb_find_mode() will produce a blank display.

Add this new option to Documentation/fb/aty128fb.txt

We do not have documentation file for aty.
In other Part:

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click